From 25848af55647251d0ba882e1640d08dd1fce7875 Mon Sep 17 00:00:00 2001 From: Jean Chalard Date: Tue, 3 Dec 2013 15:42:59 +0900 Subject: [PATCH] Tiny refactoring Add a warning comment and make it so that openNative() is only called in one place in the code. Bug: 11281748 Change-Id: Ic7819a01deb62cf145ebf9d620da2d15fae19313 --- java/src/com/android/inputmethod/latin/BinaryDictionary.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/java/src/com/android/inputmethod/latin/BinaryDictionary.java b/java/src/com/android/inputmethod/latin/BinaryDictionary.java index 4fa682d66..174bbfb8e 100644 --- a/java/src/com/android/inputmethod/latin/BinaryDictionary.java +++ b/java/src/com/android/inputmethod/latin/BinaryDictionary.java @@ -376,7 +376,10 @@ public final class BinaryDictionary extends Dictionary { private void reopen() { close(); final File dictFile = new File(mDictFilePath); - mNativeDict = openNative(dictFile.getAbsolutePath(), 0 /* startOffset */, + // WARNING: Because we pass 0 as the offstet and file.length() as the length, this can + // only be called for actual files. Right now it's only called by the flush() family of + // functions, which require an updatable dictionary, so it's okay. But beware. + loadDictionary(dictFile.getAbsolutePath(), 0 /* startOffset */, dictFile.length(), true /* isUpdatable */); }