From cbfd2e1fdb83a2fc315b5b6351221f3d65afe25a Mon Sep 17 00:00:00 2001 From: Jean Chalard Date: Fri, 29 Jun 2012 15:42:29 +0900 Subject: [PATCH] Pull up a common variable into the wrapping method (A50) Change-Id: I0b62098308169b5c44ced25ffb902766e3732fbf --- .../android/inputmethod/latin/LatinIME.java | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/java/src/com/android/inputmethod/latin/LatinIME.java b/java/src/com/android/inputmethod/latin/LatinIME.java index 4089462e8..2d81298b0 100644 --- a/java/src/com/android/inputmethod/latin/LatinIME.java +++ b/java/src/com/android/inputmethod/latin/LatinIME.java @@ -1708,17 +1708,19 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen return; } + final CharSequence typedWord; if (isPredictions || !mWordComposer.isComposingWord()) { - updateBigramPredictions(); + typedWord = ""; + updateBigramPredictions(typedWord); } else { - updateSuggestions(); + typedWord = mWordComposer.getTypedWord(); + updateSuggestions(typedWord); } } - private void updateSuggestions() { + private void updateSuggestions(final CharSequence typedWord) { // TODO: May need a better way of retrieving previous word final CharSequence prevWord = mConnection.getPreviousWord(mCurrentSettings.mWordSeparators); - final CharSequence typedWord = mWordComposer.getTypedWord(); // getSuggestedWords handles gracefully a null value of prevWord final SuggestedWords suggestedWords = mSuggest.getSuggestedWords(mWordComposer, prevWord, mKeyboardSwitcher.getKeyboard().getProximityInfo(), @@ -1925,7 +1927,7 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen separatorCode, prevWord); } - private void updateBigramPredictions() { + private void updateBigramPredictions(final CharSequence typedWord) { if (!mCurrentSettings.mBigramPredictionEnabled) { setPunctuationSuggestions(); return; @@ -1946,9 +1948,9 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen } if (null != suggestedWords && suggestedWords.size() > 0) { - // Explicitly supply an empty typed word (the no-second-arg version of - // showSuggestions will retrieve the word near the cursor, we don't want that here) - showSuggestions(suggestedWords, ""); + // Typed word is always empty. We pass it because the no-second-arg version of + // showSuggestions will retrieve the word near the cursor, and we don't want that here + showSuggestions(suggestedWords, typedWord); } else { clearSuggestions(); }