diff --git a/java/res/drawable-hdpi/sym_keyboard_feedback_tab.png b/java/res/drawable-hdpi/sym_keyboard_feedback_tab.png deleted file mode 100644 index d85663bf3..000000000 Binary files a/java/res/drawable-hdpi/sym_keyboard_feedback_tab.png and /dev/null differ diff --git a/java/res/drawable-mdpi/sym_keyboard_feedback_tab.png b/java/res/drawable-mdpi/sym_keyboard_feedback_tab.png deleted file mode 100644 index fee15807c..000000000 Binary files a/java/res/drawable-mdpi/sym_keyboard_feedback_tab.png and /dev/null differ diff --git a/java/res/drawable-xhdpi/sym_keyboard_feedback_tab.png b/java/res/drawable-xhdpi/sym_keyboard_feedback_tab.png deleted file mode 100644 index b0ee35d59..000000000 Binary files a/java/res/drawable-xhdpi/sym_keyboard_feedback_tab.png and /dev/null differ diff --git a/java/res/values/attrs.xml b/java/res/values/attrs.xml index 396c166ab..64879551f 100644 --- a/java/res/values/attrs.xml +++ b/java/res/values/attrs.xml @@ -238,7 +238,6 @@ - @@ -331,8 +330,6 @@ - - diff --git a/java/res/values/keyboard-icons-holo.xml b/java/res/values/keyboard-icons-holo.xml index 669d2c07d..d95ff8201 100644 --- a/java/res/values/keyboard-icons-holo.xml +++ b/java/res/values/keyboard-icons-holo.xml @@ -32,7 +32,6 @@ @drawable/sym_keyboard_space_holo_dark @drawable/sym_keyboard_shift_locked_holo_dark @drawable/sym_keyboard_voice_off_holo_dark - @drawable/sym_keyboard_feedback_tab @drawable/sym_keyboard_language_switch_dark @drawable/sym_keyboard_zwnj_holo_dark @drawable/sym_keyboard_zwj_holo_dark diff --git a/java/res/values/keyboard-icons-lxx-dark.xml b/java/res/values/keyboard-icons-lxx-dark.xml index 6e9c4d1c1..7988e739e 100644 --- a/java/res/values/keyboard-icons-lxx-dark.xml +++ b/java/res/values/keyboard-icons-lxx-dark.xml @@ -38,7 +38,6 @@ @drawable/sym_keyboard_space_holo_dark @drawable/sym_keyboard_shift_locked_lxx_dark @drawable/sym_keyboard_voice_off_lxx_dark - @drawable/sym_keyboard_feedback_tab @drawable/sym_keyboard_language_switch_lxx_dark @drawable/sym_keyboard_zwnj_holo_dark @drawable/sym_keyboard_zwj_holo_dark diff --git a/java/res/xml-sw600dp/key_styles_common.xml b/java/res/xml-sw600dp/key_styles_common.xml index 7de276901..877c796c7 100644 --- a/java/res/xml-sw600dp/key_styles_common.xml +++ b/java/res/xml-sw600dp/key_styles_common.xml @@ -121,7 +121,6 @@ diff --git a/java/res/xml/key_styles_common.xml b/java/res/xml/key_styles_common.xml index 8b3bb2e5c..bc739f7d0 100644 --- a/java/res/xml/key_styles_common.xml +++ b/java/res/xml/key_styles_common.xml @@ -119,14 +119,12 @@ + latin:keySpec="!icon/tab_key|!code/key_tab" /> { public final int mAltCode; /** Icon for disabled state */ public final int mDisabledIconId; - /** Preview version of the icon, for the preview popup */ - public final int mPreviewIconId; /** The visual insets */ public final int mVisualInsetsLeft; public final int mVisualInsetsRight; private OptionalAttributes(final String outputText, final int altCode, - final int disabledIconId, final int previewIconId, - final int visualInsetsLeft, final int visualInsetsRight) { + final int disabledIconId, final int visualInsetsLeft, final int visualInsetsRight) { mOutputText = outputText; mAltCode = altCode; mDisabledIconId = disabledIconId; - mPreviewIconId = previewIconId; mVisualInsetsLeft = visualInsetsLeft; mVisualInsetsRight = visualInsetsRight; } public static OptionalAttributes newInstance(final String outputText, final int altCode, - final int disabledIconId, final int previewIconId, - final int visualInsetsLeft, final int visualInsetsRight) { + final int disabledIconId, final int visualInsetsLeft, final int visualInsetsRight) { if (outputText == null && altCode == CODE_UNSPECIFIED - && disabledIconId == ICON_UNDEFINED && previewIconId == ICON_UNDEFINED - && visualInsetsLeft == 0 && visualInsetsRight == 0) { + && disabledIconId == ICON_UNDEFINED && visualInsetsLeft == 0 + && visualInsetsRight == 0) { return null; } - return new OptionalAttributes(outputText, altCode, disabledIconId, previewIconId, - visualInsetsLeft, visualInsetsRight); + return new OptionalAttributes(outputText, altCode, disabledIconId, visualInsetsLeft, + visualInsetsRight); } } @@ -204,8 +199,7 @@ public class Key implements Comparable { mMoreKeysColumnAndFlags = 0; mLabel = label; mOptionalAttributes = OptionalAttributes.newInstance(outputText, CODE_UNSPECIFIED, - ICON_UNDEFINED, ICON_UNDEFINED, - 0 /* visualInsetsLeft */, 0 /* visualInsetsRight */); + ICON_UNDEFINED, 0 /* visualInsetsLeft */, 0 /* visualInsetsRight */); mCode = code; mEnabled = (code != CODE_UNSPECIFIED); mIconId = iconId; @@ -306,8 +300,6 @@ public class Key implements Comparable { mIconId = KeySpecParser.getIconId(keySpec); final int disabledIconId = KeySpecParser.getIconId(style.getString(keyAttr, R.styleable.Keyboard_Key_keyIconDisabled)); - final int previewIconId = KeySpecParser.getIconId(style.getString(keyAttr, - R.styleable.Keyboard_Key_keyIconPreview)); final int code = KeySpecParser.getCode(keySpec); if ((mLabelFlags & LABEL_FLAGS_FROM_CUSTOM_ACTION_LABEL) != 0) { @@ -361,7 +353,7 @@ public class Key implements Comparable { final int altCode = StringUtils.toUpperCaseOfCodeForLocale( altCodeInAttr, needsToUpperCase, locale); mOptionalAttributes = OptionalAttributes.newInstance(outputText, altCode, - disabledIconId, previewIconId, visualInsetsLeft, visualInsetsRight); + disabledIconId, visualInsetsLeft, visualInsetsRight); mKeyVisualAttributes = KeyVisualAttributes.newInstance(keyAttr); mHashCode = computeHashCode(this); } @@ -756,10 +748,7 @@ public class Key implements Comparable { } public Drawable getPreviewIcon(final KeyboardIconsSet iconSet) { - final OptionalAttributes attrs = mOptionalAttributes; - final int previewIconId = (attrs != null) ? attrs.mPreviewIconId : ICON_UNDEFINED; - return previewIconId != ICON_UNDEFINED - ? iconSet.getIconDrawable(previewIconId) : iconSet.getIconDrawable(getIconId()); + return iconSet.getIconDrawable(getIconId()); } public int getWidth() { diff --git a/java/src/com/android/inputmethod/keyboard/internal/KeyStylesSet.java b/java/src/com/android/inputmethod/keyboard/internal/KeyStylesSet.java index 0b0e761d2..5cbb34119 100644 --- a/java/src/com/android/inputmethod/keyboard/internal/KeyStylesSet.java +++ b/java/src/com/android/inputmethod/keyboard/internal/KeyStylesSet.java @@ -141,7 +141,6 @@ public final class KeyStylesSet { readStringArray(keyAttr, R.styleable.Keyboard_Key_additionalMoreKeys); readFlags(keyAttr, R.styleable.Keyboard_Key_keyLabelFlags); readString(keyAttr, R.styleable.Keyboard_Key_keyIconDisabled); - readString(keyAttr, R.styleable.Keyboard_Key_keyIconPreview); readInt(keyAttr, R.styleable.Keyboard_Key_maxMoreKeysColumn); readInt(keyAttr, R.styleable.Keyboard_Key_backgroundType); readFlags(keyAttr, R.styleable.Keyboard_Key_keyActionFlags); diff --git a/java/src/com/android/inputmethod/keyboard/internal/KeyboardIconsSet.java b/java/src/com/android/inputmethod/keyboard/internal/KeyboardIconsSet.java index 7146deb4b..09550c4cb 100644 --- a/java/src/com/android/inputmethod/keyboard/internal/KeyboardIconsSet.java +++ b/java/src/com/android/inputmethod/keyboard/internal/KeyboardIconsSet.java @@ -48,7 +48,6 @@ public final class KeyboardIconsSet { public static final String NAME_DONE_KEY = "done_key"; public static final String NAME_PREVIOUS_KEY = "previous_key"; public static final String NAME_TAB_KEY = "tab_key"; - public static final String NANE_TAB_KEY_PREVIEW = "tab_key_preview"; public static final String NAME_SHORTCUT_KEY = "shortcut_key"; public static final String NAME_SHORTCUT_KEY_DISABLED = "shortcut_key_disabled"; public static final String NAME_LANGUAGE_SWITCH_KEY = "language_switch_key"; @@ -79,7 +78,6 @@ public final class KeyboardIconsSet { NAME_SPACE_KEY_FOR_NUMBER_LAYOUT, R.styleable.Keyboard_iconSpaceKeyForNumberLayout, NAME_SHIFT_KEY_SHIFTED, R.styleable.Keyboard_iconShiftKeyShifted, NAME_SHORTCUT_KEY_DISABLED, R.styleable.Keyboard_iconShortcutKeyDisabled, - NANE_TAB_KEY_PREVIEW, R.styleable.Keyboard_iconTabKeyPreview, NAME_LANGUAGE_SWITCH_KEY, R.styleable.Keyboard_iconLanguageSwitchKey, NAME_ZWNJ_KEY, R.styleable.Keyboard_iconZwnjKey, NAME_ZWJ_KEY, R.styleable.Keyboard_iconZwjKey,