nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge "Use an iterator to remove stuff from an ArrayList."

main
Jean Chalard 2013-06-06 08:19:41 +00:00 committed by Android (Google) Code Review
parent f6a1a76524 0dc422e0c7
commit 6910032972
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
java/src/com/android/inputmethod/latin/DictionaryInfoUtils.java
View File

@ -30,6 +30,7 @@ import com.android.inputmethod.latin.makedict.UnsupportedFormatException;
import java.io.File; import java.io.File;
import java.io.IOException; import java.io.IOException;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Iterator;
import java.util.Locale; import java.util.Locale;
/** /**
@ -301,12 +302,14 @@ public class DictionaryInfoUtils {
private static void addOrUpdateDictInfo(final ArrayList<DictionaryInfo> dictList, private static void addOrUpdateDictInfo(final ArrayList<DictionaryInfo> dictList,
final DictionaryInfo newElement) { final DictionaryInfo newElement) {
for (final DictionaryInfo info : dictList) { final Iterator<DictionaryInfo> iter = dictList.iterator();
if (info.mLocale.equals(newElement.mLocale)) { while (iter.hasNext()) {
if (newElement.mVersion <= info.mVersion) { final DictionaryInfo thisDictInfo = iter.next();
if (thisDictInfo.mLocale.equals(newElement.mLocale)) {
if (newElement.mVersion <= thisDictInfo.mVersion) {
return; return;
} }
dictList.remove(info); iter.remove();
} }
} }
dictList.add(newElement); dictList.add(newElement);