nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge "Never pass negative values to setSelection."

main
Jean Chalard 2014-02-24 09:26:43 +00:00 committed by Android (Google) Code Review
parent b08a9e021c f19745728e
commit 65bce4cabc
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
java/src/com/android/inputmethod/latin/RichInputConnection.java
View File

@ -483,12 +483,16 @@ public final class RichInputConnection {
* *
* @param start the character index where the selection should start. * @param start the character index where the selection should start.
* @param end the character index where the selection should end. * @param end the character index where the selection should end.
* @return Returns true on success, false if the input connection is no longer valid either when * @return Returns true on success, false on failure: either the input connection is no longer
* setting the selection or when retrieving the text cache at that point. * valid when setting the selection or when retrieving the text cache at that point, or
* invalid arguments were passed.
*/ */
public boolean setSelection(final int start, final int end) { public boolean setSelection(final int start, final int end) {
if (DEBUG_BATCH_NESTING) checkBatchEdit(); if (DEBUG_BATCH_NESTING) checkBatchEdit();
if (DEBUG_PREVIOUS_TEXT) checkConsistencyForDebug(); if (DEBUG_PREVIOUS_TEXT) checkConsistencyForDebug();
if (start < 0 || end < 0) {
return false;
}
mExpectedSelStart = start; mExpectedSelStart = start;
mExpectedSelEnd = end; mExpectedSelEnd = end;
if (null != mIC) { if (null != mIC) {