From 649de3f544d8e320ab812e829f637cd5f78b3d55 Mon Sep 17 00:00:00 2001 From: "Tadashi G. Takaoka" Date: Mon, 7 Jul 2014 16:54:00 +0900 Subject: [PATCH] Fix Sinhala keyboard for tablet device This CL introduces fontDefault flag to keyLabelFlags of Key attribute to reset font specification to keyTypeface attribute. This is a followup of I065824f3fa. Bug: 6911143 Change-Id: I33bd4a23aaea73e2b17175ddd39053ec915d5451 --- java/res/values/attrs.xml | 1 + .../res/xml-sw600dp/keys_exclamation_question.xml | 6 ++++-- java/res/xml-sw600dp/rows_sinhala.xml | 3 +++ .../src/com/android/inputmethod/keyboard/Key.java | 15 ++++++++++----- 4 files changed, 18 insertions(+), 7 deletions(-) diff --git a/java/res/values/attrs.xml b/java/res/values/attrs.xml index 3206413ca..396c166ab 100644 --- a/java/res/values/attrs.xml +++ b/java/res/values/attrs.xml @@ -298,6 +298,7 @@ + diff --git a/java/res/xml-sw600dp/keys_exclamation_question.xml b/java/res/xml-sw600dp/keys_exclamation_question.xml index 97bd95d6a..cf2c61ead 100644 --- a/java/res/xml-sw600dp/keys_exclamation_question.xml +++ b/java/res/xml-sw600dp/keys_exclamation_question.xml @@ -23,8 +23,10 @@ > + latin:moreKeys="!text/morekeys_exclamation" + latin:keyLabelFlags="fontDefault" /> + latin:moreKeys="!text/morekeys_question" + latin:keyLabelFlags="fontDefault" /> diff --git a/java/res/xml-sw600dp/rows_sinhala.xml b/java/res/xml-sw600dp/rows_sinhala.xml index 23c3f3aab..d3a5ca535 100644 --- a/java/res/xml-sw600dp/rows_sinhala.xml +++ b/java/res/xml-sw600dp/rows_sinhala.xml @@ -25,6 +25,7 @@ latin:keyboardLayout="@xml/key_styles_common" /> @@ -34,6 +35,7 @@ @@ -43,6 +45,7 @@ { private static final int LABEL_FLAGS_ALIGN_RIGHT = 0x02; private static final int LABEL_FLAGS_ALIGN_BUTTOM = 0x04; private static final int LABEL_FLAGS_ALIGN_LEFT_OF_CENTER = 0x08; + // Font typeface specification. + private static final int LABEL_FLAGS_FONT_MASK = 0x30; private static final int LABEL_FLAGS_FONT_NORMAL = 0x10; private static final int LABEL_FLAGS_FONT_MONO_SPACE = 0x20; + private static final int LABEL_FLAGS_FONT_DEFAULT = 0x30; // Start of key text ratio enum values private static final int LABEL_FLAGS_FOLLOW_KEY_TEXT_RATIO_MASK = 0x1C0; private static final int LABEL_FLAGS_FOLLOW_KEY_LARGE_LETTER_RATIO = 0x40; @@ -567,14 +570,16 @@ public class Key implements Comparable { } public final Typeface selectTypeface(final KeyDrawParams params) { - // TODO: Handle "bold" here too? - if ((mLabelFlags & LABEL_FLAGS_FONT_NORMAL) != 0) { + switch (mLabelFlags & LABEL_FLAGS_FONT_MASK) { + case LABEL_FLAGS_FONT_NORMAL: return Typeface.DEFAULT; - } - if ((mLabelFlags & LABEL_FLAGS_FONT_MONO_SPACE) != 0) { + case LABEL_FLAGS_FONT_MONO_SPACE: return Typeface.MONOSPACE; + case LABEL_FLAGS_FONT_DEFAULT: + default: + // The type-face is specified by keyTypeface attribute. + return params.mTypeface; } - return params.mTypeface; } public final int selectTextSize(final KeyDrawParams params) {