am 051ac1ef: Merge "Add a guard against OOB."

* commit '051ac1ef143113df7f8b7b2a693b8c5b8d8c38ca':
  Add a guard against OOB.
main
Jean Chalard 2012-01-25 21:24:23 -08:00 committed by Android Git Automerger
commit 5f859f20a0
1 changed files with 7 additions and 3 deletions

View File

@ -2229,10 +2229,14 @@ public class LatinIME extends InputMethodServiceCompatWrapper implements Keyboar
final CharSequence textBeforeCursor = ic.getTextBeforeCursor(2, 0); final CharSequence textBeforeCursor = ic.getTextBeforeCursor(2, 0);
// NOTE: This does not work with surrogate pairs. Hopefully when the keyboard is able to // NOTE: This does not work with surrogate pairs. Hopefully when the keyboard is able to
// enter surrogate pairs this code will have been removed. // enter surrogate pairs this code will have been removed.
if (Keyboard.CODE_SPACE != textBeforeCursor.charAt(1)) { if (TextUtils.isEmpty(textBeforeCursor)
// We should not have come here if the text before the cursor is not a space. || (Keyboard.CODE_SPACE != textBeforeCursor.charAt(1))) {
throw new RuntimeException("Tried to revert a swap of punctuation but we didn't " // We may only come here if the application is changing the text while we are typing.
// This is quite a broken case, but not logically impossible, so we shouldn't crash,
// but some debugging log may be in order.
Log.d(TAG, "Tried to revert a swap of punctuation but we didn't "
+ "find a space just before the cursor."); + "find a space just before the cursor.");
return false;
} }
ic.beginBatchEdit(); ic.beginBatchEdit();
ic.deleteSurroundingText(2, 0); ic.deleteSurroundingText(2, 0);