nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge "[IL74] Remove unused/unwanted arguments to a method."

main
Jean Chalard 2014-01-27 08:57:11 +00:00 committed by Android (Google) Code Review
parent 0b58617951 0fd556ceca
commit 5cf70a1d44
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
java/src/com/android/inputmethod/latin/LatinIME.java
View File

@ -888,10 +888,7 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen
mInputLogic.finishInput(); mInputLogic.finishInput();
// Notify ResearchLogger // Notify ResearchLogger
if (ProductionFlag.USES_DEVELOPMENT_ONLY_DIAGNOSTICS) { if (ProductionFlag.USES_DEVELOPMENT_ONLY_DIAGNOSTICS) {
ResearchLogger.latinIME_onFinishInputViewInternal(finishingInput, ResearchLogger.latinIME_onFinishInputViewInternal(finishingInput);
// TODO[IL]: mInputLogic.mConnection should be private
mInputLogic.mConnection.getExpectedSelectionStart(),
mInputLogic.mConnection.getExpectedSelectionEnd(), getCurrentInputConnection());
} }
} }

5
java/src/com/android/inputmethod/research/ResearchLogger.java
View File

@ -1117,14 +1117,13 @@ public class ResearchLogger implements SharedPreferences.OnSharedPreferenceChang
private static final LogStatement LOGSTATEMENT_LATINIME_ONFINISHINPUTVIEWINTERNAL = private static final LogStatement LOGSTATEMENT_LATINIME_ONFINISHINPUTVIEWINTERNAL =
new LogStatement("LatinIMEOnFinishInputViewInternal", false, false, "isTextTruncated", new LogStatement("LatinIMEOnFinishInputViewInternal", false, false, "isTextTruncated",
"text"); "text");
public static void latinIME_onFinishInputViewInternal(final boolean finishingInput, public static void latinIME_onFinishInputViewInternal(final boolean finishingInput) {
final int savedSelectionStart, final int savedSelectionEnd, final InputConnection ic) {
// The finishingInput flag is set in InputMethodService. It is true if called from // The finishingInput flag is set in InputMethodService. It is true if called from
// doFinishInput(), which can be called as part of doStartInput(). This can happen at times // doFinishInput(), which can be called as part of doStartInput(). This can happen at times
// when the IME is not closing, such as when powering up. The finishinInput flag is false // when the IME is not closing, such as when powering up. The finishinInput flag is false
// if called from finishViews(), which is called from hideWindow() and onDestroy(). These // if called from finishViews(), which is called from hideWindow() and onDestroy(). These
// are the situations in which we want to finish up the researchLog. // are the situations in which we want to finish up the researchLog.
if (ic != null && !finishingInput) { if (!finishingInput) {
final ResearchLogger researchLogger = getInstance(); final ResearchLogger researchLogger = getInstance();
// Assume that OUTPUT_ENTIRE_BUFFER is only true when we don't care about privacy (e.g. // Assume that OUTPUT_ENTIRE_BUFFER is only true when we don't care about privacy (e.g.
// during a live user test), so the normal isPotentiallyPrivate and // during a live user test), so the normal isPotentiallyPrivate and