From 2d3e121014a97b7de90f287f1ef82fa98f37007c Mon Sep 17 00:00:00 2001 From: Satoshi Kataoka Date: Tue, 8 Oct 2013 18:54:24 +0900 Subject: [PATCH] Fix memory leak in EmojiPaletteView Bug: 10902556 Change-Id: I3a8c1e08d6f953b462d914acd1f411c36f9d80f2 --- .../android/inputmethod/keyboard/EmojiPalettesView.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java b/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java index ef9448c2f..5c518b8f1 100644 --- a/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java +++ b/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java @@ -694,13 +694,16 @@ public final class EmojiPalettesView extends LinearLayout implements OnTabChange @Override public void destroyItem(final ViewGroup container, final int position, final Object object) { - ScrollKeyboardView keyboardView = mActiveKeyboardViews.get(position); + final ScrollKeyboardView keyboardView = mActiveKeyboardViews.get(position); if (keyboardView != null) { keyboardView.deallocateMemory(); mActiveKeyboardViews.remove(position); } - container.removeView(keyboardView); - keyboardView = null; + if (object instanceof View) { + container.removeView((View)object); + } else { + Log.w(TAG, "Warning!!! Emoji palette may be leaking. " + object); + } } }