Fix NPE in user history bigram dictionary
Bug: 6584882 Change-Id: Id0162bffc4f0f36239cdc68383f8a47d7a957397main
parent
6f0cd9ba6d
commit
4f96bb4520
|
@ -454,6 +454,8 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen
|
||||||
|
|
||||||
// Has to be package-visible for unit tests
|
// Has to be package-visible for unit tests
|
||||||
/* package */ void loadSettings() {
|
/* package */ void loadSettings() {
|
||||||
|
// Note that the calling sequence of onCreate() and onCurrentInputMethodSubtypeChanged()
|
||||||
|
// is not guaranteed. It may even be called at the same time on a different thread.
|
||||||
if (null == mPrefs) mPrefs = PreferenceManager.getDefaultSharedPreferences(this);
|
if (null == mPrefs) mPrefs = PreferenceManager.getDefaultSharedPreferences(this);
|
||||||
final RunInLocale<SettingsValues> job = new RunInLocale<SettingsValues>() {
|
final RunInLocale<SettingsValues> job = new RunInLocale<SettingsValues>() {
|
||||||
@Override
|
@Override
|
||||||
|
@ -495,6 +497,9 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen
|
||||||
|
|
||||||
resetContactsDictionary(oldContactsDictionary);
|
resetContactsDictionary(oldContactsDictionary);
|
||||||
|
|
||||||
|
// Note that the calling sequence of onCreate() and onCurrentInputMethodSubtypeChanged()
|
||||||
|
// is not guaranteed. It may even be called at the same time on a different thread.
|
||||||
|
if (null == mPrefs) mPrefs = PreferenceManager.getDefaultSharedPreferences(this);
|
||||||
mUserHistoryDictionary = new UserHistoryDictionary(
|
mUserHistoryDictionary = new UserHistoryDictionary(
|
||||||
this, localeStr, Suggest.DIC_USER_HISTORY, mPrefs);
|
this, localeStr, Suggest.DIC_USER_HISTORY, mPrefs);
|
||||||
mSuggest.setUserHistoryDictionary(mUserHistoryDictionary);
|
mSuggest.setUserHistoryDictionary(mUserHistoryDictionary);
|
||||||
|
@ -624,6 +629,8 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void onCurrentInputMethodSubtypeChanged(InputMethodSubtype subtype) {
|
public void onCurrentInputMethodSubtypeChanged(InputMethodSubtype subtype) {
|
||||||
|
// Note that the calling sequence of onCreate() and onCurrentInputMethodSubtypeChanged()
|
||||||
|
// is not guaranteed. It may even be called at the same time on a different thread.
|
||||||
mSubtypeSwitcher.updateSubtype(subtype);
|
mSubtypeSwitcher.updateSubtype(subtype);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue