From 77e26e1c29632b73997cfaea9cd9ebb57a2dea73 Mon Sep 17 00:00:00 2001 From: Jean Chalard Date: Thu, 18 Apr 2013 23:11:43 +0900 Subject: [PATCH] Fix an infinite loop What do you mean "Can't happen"? It happens all the time - the empty string is the default ID, and it needs to be updated like everyone else. Bug: 8651858 Change-Id: I5a2f2ebb5b2ef08b27f26be8fb2c3d2f231ebcfc --- .../com/android/inputmethod/dictionarypack/UpdateHandler.java | 1 - 1 file changed, 1 deletion(-) diff --git a/java/src/com/android/inputmethod/dictionarypack/UpdateHandler.java b/java/src/com/android/inputmethod/dictionarypack/UpdateHandler.java index e05a79b7b..3173e911b 100644 --- a/java/src/com/android/inputmethod/dictionarypack/UpdateHandler.java +++ b/java/src/com/android/inputmethod/dictionarypack/UpdateHandler.java @@ -181,7 +181,6 @@ public final class UpdateHandler { if (!cursor.moveToFirst()) return; do { final String clientId = cursor.getString(0); - if (TextUtils.isEmpty(clientId)) continue; // This probably can't happen final String metadataUri = MetadataDbHelper.getMetadataUriAsString(context, clientId); PrivateLog.log("Update for clientId " + Utils.s(clientId), context);