From 45eb5d924d245618ec6066f631a99779617de057 Mon Sep 17 00:00:00 2001 From: "Tadashi G. Takaoka" Date: Sun, 9 Feb 2014 22:01:23 +0900 Subject: [PATCH] Allow an empty keySpec for Spacer Bug: 12933248 Change-Id: I76432556caf319ce23c1fb7fa3d6b94118e64cf8 --- java/src/com/android/inputmethod/keyboard/Key.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/java/src/com/android/inputmethod/keyboard/Key.java b/java/src/com/android/inputmethod/keyboard/Key.java index 1c8bada15..aade490ac 100644 --- a/java/src/com/android/inputmethod/keyboard/Key.java +++ b/java/src/com/android/inputmethod/keyboard/Key.java @@ -316,8 +316,10 @@ public class Key implements Comparable { mActionFlags = actionFlags; final String keySpec = style.getString(keyAttr, R.styleable.Keyboard_Key_keySpec); - if (TextUtils.isEmpty(keySpec)) { - throw new RuntimeException("Empty keySpec"); + // Note: {@link Spacer} has an empty keySpec. + // TODO: Create a Key constructor that parses only key geometries and share it with Spacer. + if (TextUtils.isEmpty(keySpec) && !(this instanceof Spacer)) { + throw new RuntimeException("Empty keySpec found in " + getClass().getName()); } mIconId = KeySpecParser.getIconId(keySpec);