nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge "Ensure Preference listener is unregistered"

Browse source
This commit is contained in:
Kurt Partridge 2013-02-27 03:49:40 +00:00 committed by Android (Google) Code Review
commit 424a976e58
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
java/src/com/android/inputmethod/latin/LatinIME.java
View file

@ -561,6 +561,9 @@ public final class LatinIME extends InputMethodService implements KeyboardAction
} }
mSettings.onDestroy(); mSettings.onDestroy();
unregisterReceiver(mReceiver); unregisterReceiver(mReceiver);
if (ProductionFlag.IS_EXPERIMENTAL) {
ResearchLogger.getInstance().onDestroy();
}
// TODO: The experimental version is not supported by the Dictionary Pack Service yet. // TODO: The experimental version is not supported by the Dictionary Pack Service yet.
if (!ProductionFlag.IS_EXPERIMENTAL) { if (!ProductionFlag.IS_EXPERIMENTAL) {
unregisterReceiver(mDictionaryPackInstallReceiver); unregisterReceiver(mDictionaryPackInstallReceiver);

6
java/src/com/android/inputmethod/research/ResearchLogger.java
View file

@ -322,6 +322,12 @@ public class ResearchLogger implements SharedPreferences.OnSharedPreferenceChang
mMainKeyboardView = null; mMainKeyboardView = null;
} }
public void onDestroy() {
if (mPrefs != null) {
mPrefs.unregisterOnSharedPreferenceChangeListener(this);
}
}
private boolean hasSeenSplash() { private boolean hasSeenSplash() {
return mPrefs.getBoolean(PREF_RESEARCH_HAS_SEEN_SPLASH, false); return mPrefs.getBoolean(PREF_RESEARCH_HAS_SEEN_SPLASH, false);
} }