nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix a concurrency bug that ends up in a crash. 

Bug: 18085768
Change-Id: I016bec997787839526ddfc521ebb99d0c7b05189
main
Jean Chalard 2014-10-23 12:36:42 +09:00
parent d3a4c51324
commit 4097a20b36
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
java/src/com/android/inputmethod/latin/RichInputConnection.java
View File

@ -367,7 +367,9 @@ public final class RichInputConnection implements PrivateCommandPerformer {
} }
// This never calls InputConnection#getCapsMode - in fact, it's a static method that // This never calls InputConnection#getCapsMode - in fact, it's a static method that
// never blocks or initiates IPC. // never blocks or initiates IPC.
return CapsModeUtils.getCapsMode(mCommittedTextBeforeComposingText, inputType, // TODO: don't call #toString() here. Instead, all accesses to
// mCommittedTextBeforeComposingText should be done on the main thread.
return CapsModeUtils.getCapsMode(mCommittedTextBeforeComposingText.toString(), inputType,
spacingAndPunctuations, hasSpaceBefore); spacingAndPunctuations, hasSpaceBefore);
} }