nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge "[IL15] Some small refactoring"

Browse source
This commit is contained in:
Jean Chalard 2013-12-20 02:42:09 +00:00 committed by Android (Google) Code Review
commit 30e3b66fa3
5 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
java/src/com/android/inputmethod/latin/LatinIME.java
View file

@ -1299,8 +1299,7 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen
mUserDictionary.addWordToUserDictionary(wordToEdit); mUserDictionary.addWordToUserDictionary(wordToEdit);
} }
// TODO[IL]: Rework the route through which this is called. public void displaySettingsDialog() {
public void onSettingsKeyPressed() {
if (isShowingOptionDialog()) return; if (isShowingOptionDialog()) return;
showSubtypeSelectorAndSettings(); showSubtypeSelectorAndSettings();
} }
@ -2375,7 +2374,7 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen
final CharSequence[] items = new CharSequence[] { final CharSequence[] items = new CharSequence[] {
// TODO: Should use new string "Select active input modes". // TODO: Should use new string "Select active input modes".
getString(R.string.language_selection_title), getString(R.string.language_selection_title),
getString(ApplicationUtils.getAcitivityTitleResId(this, SettingsActivity.class)), getString(ApplicationUtils.getActivityTitleResId(this, SettingsActivity.class)),
}; };
final DialogInterface.OnClickListener listener = new DialogInterface.OnClickListener() { final DialogInterface.OnClickListener listener = new DialogInterface.OnClickListener() {
@Override @Override

2
java/src/com/android/inputmethod/latin/inputlogic/InputLogic.java
View file

@ -999,7 +999,7 @@ public final class InputLogic {
* Handle a press on the settings key. * Handle a press on the settings key.
*/ */
private void onSettingsKeyPressed() { private void onSettingsKeyPressed() {
mLatinIME.onSettingsKeyPressed(); mLatinIME.displaySettingsDialog();
} }
/** /**

2
java/src/com/android/inputmethod/latin/settings/SettingsFragment.java
View file

@ -98,7 +98,7 @@ public final class SettingsFragment extends InputMethodSettingsFragment
final PreferenceScreen preferenceScreen = getPreferenceScreen(); final PreferenceScreen preferenceScreen = getPreferenceScreen();
if (preferenceScreen != null) { if (preferenceScreen != null) {
preferenceScreen.setTitle( preferenceScreen.setTitle(
ApplicationUtils.getAcitivityTitleResId(getActivity(), SettingsActivity.class)); ApplicationUtils.getActivityTitleResId(getActivity(), SettingsActivity.class));
} }
final Resources res = getResources(); final Resources res = getResources();

2
java/src/com/android/inputmethod/latin/spellcheck/SpellCheckerSettingsFragment.java
View file

@ -39,7 +39,7 @@ public final class SpellCheckerSettingsFragment extends PreferenceFragment {
addPreferencesFromResource(R.xml.spell_checker_settings); addPreferencesFromResource(R.xml.spell_checker_settings);
final PreferenceScreen preferenceScreen = getPreferenceScreen(); final PreferenceScreen preferenceScreen = getPreferenceScreen();
if (preferenceScreen != null) { if (preferenceScreen != null) {
preferenceScreen.setTitle(ApplicationUtils.getAcitivityTitleResId( preferenceScreen.setTitle(ApplicationUtils.getActivityTitleResId(
getActivity(), SpellCheckerSettingsActivity.class)); getActivity(), SpellCheckerSettingsActivity.class));
} }
} }

2
java/src/com/android/inputmethod/latin/utils/ApplicationUtils.java
View file

@ -31,7 +31,7 @@ public final class ApplicationUtils {
// This utility class is not publicly instantiable. // This utility class is not publicly instantiable.
} }
public static int getAcitivityTitleResId(final Context context, public static int getActivityTitleResId(final Context context,
final Class<? extends Activity> cls) { final Class<? extends Activity> cls) {
final ComponentName cn = new ComponentName(context, cls); final ComponentName cn = new ComponentName(context, cls);
try { try {