From 303f440311537c1a5c7823d6de0579ccf7481a85 Mon Sep 17 00:00:00 2001 From: "Tadashi G. Takaoka" Date: Thu, 3 Apr 2014 14:47:38 +0900 Subject: [PATCH] Refactor Devanagari key-styles Change-Id: I799b04317d5b7daff4bb230294b2de474e5585eb --- ... => keystyle_devanagari_sign_anusvara.xml} | 3 ++- ... keystyle_devanagari_sign_candrabindu.xml} | 5 ++-- ...xml => keystyle_devanagari_sign_nukta.xml} | 13 ++++++++-- ...ystyle_devanagari_vowel_sign_candra_o.xml} | 3 ++- ...style_devanagari_vowel_sign_vocalic_r.xml} | 5 ++-- ... => keystyle_devanagari_sign_anusvara.xml} | 3 ++- ... keystyle_devanagari_sign_candrabindu.xml} | 5 ++-- ...xml => keystyle_devanagari_sign_nukta.xml} | 14 +++++++++-- ...ystyle_devanagari_vowel_sign_candra_o.xml} | 3 ++- ...style_devanagari_vowel_sign_vocalic_r.xml} | 5 ++-- java/res/xml/rowkeys_hindi1.xml | 10 ++++---- java/res/xml/rowkeys_hindi3.xml | 25 ++++++++++++++----- java/res/xml/rowkeys_nepali_romanized1.xml | 24 +++++++++++------- java/res/xml/rowkeys_nepali_romanized3.xml | 8 ++++-- java/res/xml/rowkeys_nepali_traditional1.xml | 4 ++- java/res/xml/rowkeys_nepali_traditional2.xml | 4 ++- .../rowkeys_nepali_traditional3_right3.xml | 8 +++--- .../rowkeys_nepali_traditional3_right5.xml | 6 +++-- .../keyboard/layout/NepaliRomanized.java | 3 +-- 19 files changed, 104 insertions(+), 47 deletions(-) rename java/res/xml-v16/{key_devanagari_sign_anusvara.xml => keystyle_devanagari_sign_anusvara.xml} (94%) rename java/res/xml-v16/{key_devanagari_sign_candrabindu.xml => keystyle_devanagari_sign_candrabindu.xml} (92%) rename java/res/xml-v16/{key_devanagari_sign_nukta.xml => keystyle_devanagari_sign_nukta.xml} (81%) rename java/res/xml-v16/{key_devanagari_vowel_sign_candra_o.xml => keystyle_devanagari_vowel_sign_candra_o.xml} (94%) rename java/res/xml-v16/{key_devanagari_vowel_sign_vocalic_r.xml => keystyle_devanagari_vowel_sign_vocalic_r.xml} (93%) rename java/res/xml/{key_devanagari_sign_anusvara.xml => keystyle_devanagari_sign_anusvara.xml} (94%) rename java/res/xml/{key_devanagari_sign_candrabindu.xml => keystyle_devanagari_sign_candrabindu.xml} (93%) rename java/res/xml/{key_devanagari_sign_nukta.xml => keystyle_devanagari_sign_nukta.xml} (80%) rename java/res/xml/{key_devanagari_vowel_sign_candra_o.xml => keystyle_devanagari_vowel_sign_candra_o.xml} (94%) rename java/res/xml/{key_devanagari_vowel_sign_vocalic_r.xml => keystyle_devanagari_vowel_sign_vocalic_r.xml} (93%) diff --git a/java/res/xml-v16/key_devanagari_sign_anusvara.xml b/java/res/xml-v16/keystyle_devanagari_sign_anusvara.xml similarity index 94% rename from java/res/xml-v16/key_devanagari_sign_anusvara.xml rename to java/res/xml-v16/keystyle_devanagari_sign_anusvara.xml index ee0f21dad..10b1426ba 100644 --- a/java/res/xml-v16/key_devanagari_sign_anusvara.xml +++ b/java/res/xml-v16/keystyle_devanagari_sign_anusvara.xml @@ -26,7 +26,8 @@ xmlns:latin="http://schemas.android.com/apk/res/com.android.inputmethod.latin" > - diff --git a/java/res/xml-v16/key_devanagari_sign_candrabindu.xml b/java/res/xml-v16/keystyle_devanagari_sign_candrabindu.xml similarity index 92% rename from java/res/xml-v16/key_devanagari_sign_candrabindu.xml rename to java/res/xml-v16/keystyle_devanagari_sign_candrabindu.xml index f24612031..6198d01a9 100644 --- a/java/res/xml-v16/key_devanagari_sign_candrabindu.xml +++ b/java/res/xml-v16/keystyle_devanagari_sign_candrabindu.xml @@ -40,8 +40,9 @@ - diff --git a/java/res/xml-v16/key_devanagari_sign_nukta.xml b/java/res/xml-v16/keystyle_devanagari_sign_nukta.xml similarity index 81% rename from java/res/xml-v16/key_devanagari_sign_nukta.xml rename to java/res/xml-v16/keystyle_devanagari_sign_nukta.xml index 915779524..e0b47bb6f 100644 --- a/java/res/xml-v16/key_devanagari_sign_nukta.xml +++ b/java/res/xml-v16/keystyle_devanagari_sign_nukta.xml @@ -36,14 +36,23 @@ latin:styleName="moreKeysDevanagariSignNukta" latin:moreKeys="ॽ,॰,ऽ" /> + + + + - diff --git a/java/res/xml-v16/key_devanagari_vowel_sign_candra_o.xml b/java/res/xml-v16/keystyle_devanagari_vowel_sign_candra_o.xml similarity index 94% rename from java/res/xml-v16/key_devanagari_vowel_sign_candra_o.xml rename to java/res/xml-v16/keystyle_devanagari_vowel_sign_candra_o.xml index 2f1739948..f7edae0ff 100644 --- a/java/res/xml-v16/key_devanagari_vowel_sign_candra_o.xml +++ b/java/res/xml-v16/keystyle_devanagari_vowel_sign_candra_o.xml @@ -26,7 +26,8 @@ xmlns:latin="http://schemas.android.com/apk/res/com.android.inputmethod.latin" > - diff --git a/java/res/xml-v16/key_devanagari_vowel_sign_vocalic_r.xml b/java/res/xml-v16/keystyle_devanagari_vowel_sign_vocalic_r.xml similarity index 93% rename from java/res/xml-v16/key_devanagari_vowel_sign_vocalic_r.xml rename to java/res/xml-v16/keystyle_devanagari_vowel_sign_vocalic_r.xml index dc7a0e090..b49a97c84 100644 --- a/java/res/xml-v16/key_devanagari_vowel_sign_vocalic_r.xml +++ b/java/res/xml-v16/keystyle_devanagari_vowel_sign_vocalic_r.xml @@ -48,8 +48,9 @@ - diff --git a/java/res/xml/key_devanagari_sign_anusvara.xml b/java/res/xml/keystyle_devanagari_sign_anusvara.xml similarity index 94% rename from java/res/xml/key_devanagari_sign_anusvara.xml rename to java/res/xml/keystyle_devanagari_sign_anusvara.xml index 5d7c01890..0486a5dda 100644 --- a/java/res/xml/key_devanagari_sign_anusvara.xml +++ b/java/res/xml/keystyle_devanagari_sign_anusvara.xml @@ -27,7 +27,8 @@ > - diff --git a/java/res/xml/key_devanagari_sign_candrabindu.xml b/java/res/xml/keystyle_devanagari_sign_candrabindu.xml similarity index 93% rename from java/res/xml/key_devanagari_sign_candrabindu.xml rename to java/res/xml/keystyle_devanagari_sign_candrabindu.xml index 9e9c371a7..24cb44ba8 100644 --- a/java/res/xml/key_devanagari_sign_candrabindu.xml +++ b/java/res/xml/keystyle_devanagari_sign_candrabindu.xml @@ -42,8 +42,9 @@ - diff --git a/java/res/xml/key_devanagari_sign_nukta.xml b/java/res/xml/keystyle_devanagari_sign_nukta.xml similarity index 80% rename from java/res/xml/key_devanagari_sign_nukta.xml rename to java/res/xml/keystyle_devanagari_sign_nukta.xml index b56eb0af3..41da555ce 100644 --- a/java/res/xml/key_devanagari_sign_nukta.xml +++ b/java/res/xml/keystyle_devanagari_sign_nukta.xml @@ -37,6 +37,15 @@ latin:styleName="moreKeysDevanagariSignNukta" latin:moreKeys="◌ॽ|ॽ,◌॰|॰,◌ऽ|ऽ" /> + + + + @@ -44,8 +53,9 @@ - diff --git a/java/res/xml/key_devanagari_vowel_sign_candra_o.xml b/java/res/xml/keystyle_devanagari_vowel_sign_candra_o.xml similarity index 94% rename from java/res/xml/key_devanagari_vowel_sign_candra_o.xml rename to java/res/xml/keystyle_devanagari_vowel_sign_candra_o.xml index 6d7d000b3..e2c2cecf9 100644 --- a/java/res/xml/key_devanagari_vowel_sign_candra_o.xml +++ b/java/res/xml/keystyle_devanagari_vowel_sign_candra_o.xml @@ -27,7 +27,8 @@ > - diff --git a/java/res/xml/key_devanagari_vowel_sign_vocalic_r.xml b/java/res/xml/keystyle_devanagari_vowel_sign_vocalic_r.xml similarity index 93% rename from java/res/xml/key_devanagari_vowel_sign_vocalic_r.xml rename to java/res/xml/keystyle_devanagari_vowel_sign_vocalic_r.xml index badea3e2c..2268f7d47 100644 --- a/java/res/xml/key_devanagari_vowel_sign_vocalic_r.xml +++ b/java/res/xml/keystyle_devanagari_vowel_sign_vocalic_r.xml @@ -50,8 +50,9 @@ - diff --git a/java/res/xml/rowkeys_hindi1.xml b/java/res/xml/rowkeys_hindi1.xml index 5d696b32c..cff9756cf 100644 --- a/java/res/xml/rowkeys_hindi1.xml +++ b/java/res/xml/rowkeys_hindi1.xml @@ -92,9 +92,9 @@ - + - + - + - + - + + latin:keyboardLayout="@xml/keystyle_devanagari_sign_candrabindu" /> + + latin:keyboardLayout="@xml/keystyle_devanagari_vowel_sign_vocalic_r" /> + + latin:keyboardLayout="@xml/keystyle_devanagari_vowel_sign_candra_o" /> + + + latin:keyboardLayout="@xml/keystyle_devanagari_sign_anusvara" /> + - + latin:keyboardLayout="@xml/keystyle_devanagari_sign_nukta" /> + + diff --git a/java/res/xml/rowkeys_nepali_romanized1.xml b/java/res/xml/rowkeys_nepali_romanized1.xml index 3c082c2fe..616b259a3 100644 --- a/java/res/xml/rowkeys_nepali_romanized1.xml +++ b/java/res/xml/rowkeys_nepali_romanized1.xml @@ -44,7 +44,9 @@ render dotted circle for incomplete combining letter of some scripts, different set of Key definitions are needed based on the API version. --> + latin:keyboardLayout="@xml/keystyle_devanagari_vowel_sign_vocalic_r" /> + + + + U+0967: "१" DEVANAGARI DIGIT ONE --> - + - + - + - + - + + latin:keyboardLayout="@xml/keystyle_devanagari_sign_candrabindu" /> + + latin:keyboardLayout="@xml/keystyle_devanagari_sign_anusvara" /> + + latin:keyboardLayout="@xml/keystyle_devanagari_vowel_sign_vocalic_r" /> + + latin:keyboardLayout="@xml/keystyle_devanagari_sign_candrabindu" /> + + latin:keyboardLayout="@xml/keystyle_devanagari_sign_anusvara" /> + - + + latin:keyboardLayout="@xml/keystyle_devanagari_sign_anusvara" /> + - + diff --git a/tests/src/com/android/inputmethod/keyboard/layout/NepaliRomanized.java b/tests/src/com/android/inputmethod/keyboard/layout/NepaliRomanized.java index 649cd82d7..7048dbb73 100644 --- a/tests/src/com/android/inputmethod/keyboard/layout/NepaliRomanized.java +++ b/tests/src/com/android/inputmethod/keyboard/layout/NepaliRomanized.java @@ -72,8 +72,7 @@ public final class NepaliRomanized extends LayoutBase { // U+091F: "ट" DEVANAGARI LETTER TTA // U+0967: "१" DEVANAGARI DIGIT ONE // U+093C: "़" DEVANAGARI SIGN NUKTA - // TODO: Nukta should be moreKey(SIGN_NUKTA, "\u093C"). - key("\u091F", joinMoreKeys("\u0967", "1", "\u093C")), + key("\u091F", joinMoreKeys("\u0967", "1", key(SIGN_NUKTA, "\u093C"))), // U+094C: "ौ" DEVANAGARI VOWEL SIGN AU // U+0968: "२" DEVANAGARI DIGIT TWO key(VOWEL_SIGN_AU, "\u094C", joinMoreKeys("\u0968", "2")),