am ab68143a: Fix a bug where LatinIME would recorrect with no input view

* commit 'ab68143ad0fb784db38a3fd65612632fca90c789':
  Fix a bug where LatinIME would recorrect with no input view
main
Jean Chalard 2014-11-05 09:57:15 +00:00 committed by Android Git Automerger
commit 293bb7d0c0
1 changed files with 5 additions and 4 deletions

View File

@ -1077,11 +1077,12 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen
+ ", cs=" + composingSpanStart + ", ce=" + composingSpanEnd); + ", cs=" + composingSpanStart + ", ce=" + composingSpanEnd);
} }
// This call happens when we have a hardware keyboard as well as when we don't. While we // This call happens whether our view is displayed or not, but if it's not then we should
// don't support hardware keyboards yet we should avoid doing the processing associated // not attempt recorrection. This is true even with a hardware keyboard connected: if the
// with cursor movement when we have a hardware keyboard since we are not in charge. // view is not displayed we have no means of showing suggestions anyway, and if it is then
// we want to show suggestions anyway.
final SettingsValues settingsValues = mSettings.getCurrent(); final SettingsValues settingsValues = mSettings.getCurrent();
if ((!settingsValues.mHasHardwareKeyboard || ProductionFlags.IS_HARDWARE_KEYBOARD_SUPPORTED) if (isInputViewShown()
&& mInputLogic.onUpdateSelection(oldSelStart, oldSelEnd, newSelStart, newSelEnd, && mInputLogic.onUpdateSelection(oldSelStart, oldSelEnd, newSelStart, newSelEnd,
settingsValues)) { settingsValues)) {
mKeyboardSwitcher.requestUpdatingShiftState(getCurrentAutoCapsState(), mKeyboardSwitcher.requestUpdatingShiftState(getCurrentAutoCapsState(),