nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Open dictionary files always using O_RDONLY.

Browse source 
We never directly write to opened and mmapped files.

Bug: 11391620

Change-Id: Ic52fbe6018b8b3c1b6ca687461f29185809217c2
This commit is contained in:
Keisuke Kuroyanagi 2013-10-25 17:35:37 -07:00
parent c481d0556f
commit 2271c23dc6
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
native/jni/src/suggest/policyimpl/dictionary/utils/mmapped_buffer.cpp
View file

@ -30,8 +30,7 @@ namespace latinime {
/* static */ MmappedBuffer::MmappedBufferPtr MmappedBuffer::openBuffer( /* static */ MmappedBuffer::MmappedBufferPtr MmappedBuffer::openBuffer(
const char *const path, const int bufferOffset, const int bufferSize, const char *const path, const int bufferOffset, const int bufferSize,
const bool isUpdatable) { const bool isUpdatable) {
const int openMode = isUpdatable ? O_RDWR : O_RDONLY; const int mmapFd = open(path, O_RDONLY);
const int mmapFd = open(path, openMode);
if (mmapFd < 0) { if (mmapFd < 0) {
AKLOGE("DICT: Can't open the source. path=%s errno=%d", path, errno); AKLOGE("DICT: Can't open the source. path=%s errno=%d", path, errno);
return MmappedBufferPtr(0); return MmappedBufferPtr(0);