Merge "Fix a possible NPE in Dicttool"

This commit is contained in:
Jean Chalard 2014-10-06 14:17:04 +00:00 committed by Android (Google) Code Review
commit 21e57216e1

View file

@ -17,6 +17,7 @@
package android.util; package android.util;
import java.util.Arrays; import java.util.Arrays;
import java.util.Objects;
public class Pair<T1, T2> { public class Pair<T1, T2> {
public final T1 mFirst; public final T1 mFirst;
@ -29,7 +30,8 @@ public class Pair<T1, T2> {
@Override @Override
public int hashCode() { public int hashCode() {
return Arrays.hashCode(new Object[] { mFirst, mSecond }); return (mFirst == null ? 0 : mFirst.hashCode())
^ (mSecond == null ? 0 : mSecond.hashCode());
} }
@Override @Override
@ -37,7 +39,6 @@ public class Pair<T1, T2> {
if (o == this) return true; if (o == this) return true;
if (!(o instanceof Pair)) return false; if (!(o instanceof Pair)) return false;
Pair<?, ?> p = (Pair<?, ?>)o; Pair<?, ?> p = (Pair<?, ?>)o;
return ((mFirst == null && p.mFirst == null) || mFirst.equals(p.mFirst)) return Objects.equals(mFirst, p.mFirst) && Objects.equals(mSecond, p.mSecond);
&& ((mSecond == null && p.mSecond == null) || mSecond.equals(p.mSecond));
} }
} }