From ee7daefd972979898d91974ea0d92fcc9f3ca169 Mon Sep 17 00:00:00 2001 From: Jean Chalard Date: Thu, 18 Aug 2011 20:09:35 +0900 Subject: [PATCH] Check the main dict id to be able to fallback. Bug: 5095140 Change-Id: I02032923ca2a65bd8fbabc0abbe6a476f7542187 --- .../latin/BinaryDictionaryGetter.java | 27 ++++++++++++++----- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/java/src/com/android/inputmethod/latin/BinaryDictionaryGetter.java b/java/src/com/android/inputmethod/latin/BinaryDictionaryGetter.java index 18df797f0..5d2dab0a9 100644 --- a/java/src/com/android/inputmethod/latin/BinaryDictionaryGetter.java +++ b/java/src/com/android/inputmethod/latin/BinaryDictionaryGetter.java @@ -213,6 +213,13 @@ class BinaryDictionaryGetter { return cacheFiles; } + /** + * Returns the id of the main dict for a specified locale. + */ + private static String getMainDictId(final Locale locale) { + return locale.toString(); + } + /** * Returns a list of file addresses for a given locale, trying relevant methods in order. * @@ -234,12 +241,18 @@ class BinaryDictionaryGetter { BinaryDictionaryFileDumper.cacheDictionariesFromContentProvider(locale, context); final File[] cachedDictionaryList = getCachedDictionaryList(locale, context); + final String mainDictId = getMainDictId(locale); + final DictPackSettings dictPackSettings = new DictPackSettings(context); + boolean foundMainDict = false; final ArrayList fileList = new ArrayList(); // cachedDictionaryList may not be null, see doc for getCachedDictionaryList for (final File f : cachedDictionaryList) { final String wordListId = getWordListIdFromFileName(f.getName()); + if (wordListId.equals(mainDictId)) { + foundMainDict = true; + } if (!dictPackSettings.isWordListActive(wordListId)) continue; if (f.canRead()) { fileList.add(AssetFileAddress.makeFromFileName(f.getPath())); @@ -248,14 +261,14 @@ class BinaryDictionaryGetter { } } - if (!fileList.isEmpty()) { - return fileList; + if (!foundMainDict && dictPackSettings.isWordListActive(mainDictId)) { + final AssetFileAddress fallbackAsset = loadFallbackResource(context, fallbackResId, + locale); + if (null != fallbackAsset) { + fileList.add(fallbackAsset); + } } - // If the list is empty, fall through and return the fallback - final AssetFileAddress fallbackAsset = loadFallbackResource(context, fallbackResId, - locale); - if (null == fallbackAsset) return null; - return Arrays.asList(fallbackAsset); + return fileList; } }