Merge "[FileEncap4] Simplify logic"

main
Kurt Partridge 2013-03-06 20:05:47 +00:00 committed by Android (Google) Code Review
commit 1bc20700d5
1 changed files with 5 additions and 4 deletions

View File

@ -110,6 +110,10 @@ public final class UploaderService extends IntentService {
return false; return false;
} }
private boolean isConvenientToUpload() {
return isExternallyPowered() && hasWifiConnection();
}
private boolean isExternallyPowered() { private boolean isExternallyPowered() {
final Intent intent = registerReceiver(null, new IntentFilter( final Intent intent = registerReceiver(null, new IntentFilter(
Intent.ACTION_BATTERY_CHANGED)); Intent.ACTION_BATTERY_CHANGED));
@ -126,10 +130,7 @@ public final class UploaderService extends IntentService {
} }
private void doUpload(final boolean isUploadingUnconditionally) { private void doUpload(final boolean isUploadingUnconditionally) {
if (!isUploadingUnconditionally && (!isExternallyPowered() || !hasWifiConnection() if (!(isUploadingUnconditionally || isConvenientToUpload())) return;
|| IS_INHIBITING_AUTO_UPLOAD)) {
return;
}
if (mFilesDir == null) { if (mFilesDir == null) {
return; return;
} }