nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge "Fix an excessive fallback problem."

main
Jean Chalard 2011-08-23 02:12:17 -07:00 committed by Android (Google) Code Review
parent c84bc3460d 0ee3b69483
commit 1616e2e96e
1 changed files with 4 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
java/src/com/android/inputmethod/latin/DictionaryFactory.java
View File

@ -64,24 +64,10 @@ public class DictionaryFactory {
} }
} }
// null == dictList is not supposed to be possible, but better safe than sorry and it's // If the list is empty, that means we should not use any dictionary (for example, the user
// safer for future extension. In this case, rather than returning null, it should be safer // explicitly disabled the main dictionary), so the following is okay. dictList is never
// to return an empty DictionaryCollection. // null, but if for some reason it is, DictionaryCollection handles it gracefully.
if (null == dictList) { return new DictionaryCollection(dictList);
return new DictionaryCollection();
} else {
if (dictList.isEmpty()) {
// The list may be empty if no dictionaries have been added. The getter should not
// return an empty list, but if it does we end up here. Likewise, if the files
// we found could not be opened by the native code for any reason (format mismatch,
// file too big to fit in memory, etc) then we could have an empty list. In this
// case we want to fall back on the resource.
return new DictionaryCollection(createBinaryDictionary(context, fallbackResId,
locale));
} else {
return new DictionaryCollection(dictList);
}
}
} }
/** /**