nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge "Adjust settings for development-only versions"

Browse source
This commit is contained in:
Kurt Partridge 2013-06-12 16:50:55 +00:00 committed by Android (Google) Code Review
commit 14dd52b8c0
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
java/src/com/android/inputmethod/latin/SettingsFragment.java
View file

@ -42,6 +42,7 @@ import com.android.inputmethod.latin.define.ProductionFlag;
import com.android.inputmethod.latin.setup.LauncherIconVisibilityManager; import com.android.inputmethod.latin.setup.LauncherIconVisibilityManager;
import com.android.inputmethod.latin.userdictionary.UserDictionaryList; import com.android.inputmethod.latin.userdictionary.UserDictionaryList;
import com.android.inputmethod.latin.userdictionary.UserDictionarySettings; import com.android.inputmethod.latin.userdictionary.UserDictionarySettings;
import com.android.inputmethod.research.ResearchLogger;
import com.android.inputmethodcommon.InputMethodSettingsFragment; import com.android.inputmethodcommon.InputMethodSettingsFragment;
public final class SettingsFragment extends InputMethodSettingsFragment public final class SettingsFragment extends InputMethodSettingsFragment
@ -130,7 +131,12 @@ public final class SettingsFragment extends InputMethodSettingsFragment
feedbackSettings.setOnPreferenceClickListener(new OnPreferenceClickListener() { feedbackSettings.setOnPreferenceClickListener(new OnPreferenceClickListener() {
@Override @Override
public boolean onPreferenceClick(final Preference pref) { public boolean onPreferenceClick(final Preference pref) {
if (ProductionFlag.USES_DEVELOPMENT_ONLY_DIAGNOSTICS) {
// Use development-only feedback mechanism
ResearchLogger.getInstance().presentFeedbackDialogFromSettings();
} else {
FeedbackUtils.showFeedbackForm(getActivity()); FeedbackUtils.showFeedbackForm(getActivity());
}
return true; return true;
} }
}); });
@ -141,6 +147,10 @@ public final class SettingsFragment extends InputMethodSettingsFragment
miscSettings.removePreference(aboutSettings); miscSettings.removePreference(aboutSettings);
} }
} }
if (ProductionFlag.USES_DEVELOPMENT_ONLY_DIAGNOSTICS) {
// The about screen contains items that may be confusing in development-only versions.
miscSettings.removePreference(aboutSettings);
}
final boolean showVoiceKeyOption = res.getBoolean( final boolean showVoiceKeyOption = res.getBoolean(
R.bool.config_enable_show_voice_key_option); R.bool.config_enable_show_voice_key_option);

6
java/src/com/android/inputmethod/research/ResearchLogger.java
View file

@ -466,6 +466,12 @@ public class ResearchLogger implements SharedPreferences.OnSharedPreferenceChang
presentFeedbackDialog(latinIME); presentFeedbackDialog(latinIME);
} }
public void presentFeedbackDialogFromSettings() {
if (mLatinIME != null) {
presentFeedbackDialog(mLatinIME);
}
}
public void presentFeedbackDialog(final LatinIME latinIME) { public void presentFeedbackDialog(final LatinIME latinIME) {
if (isMakingUserRecording()) { if (isMakingUserRecording()) {
saveRecording(); saveRecording();