From 0ea82be889df77546956c0fe93664622fa4ccb29 Mon Sep 17 00:00:00 2001 From: "Tadashi G. Takaoka" Date: Mon, 21 Apr 2014 18:44:38 -0700 Subject: [PATCH] Remove unnecessarily getKeyFromOutputText method from Keyboard Change-Id: I61986ed65ce6696a8b0d885bdeb9668e6087bc47 --- .../android/inputmethod/keyboard/Keyboard.java | 9 --------- .../keyboard/internal/DynamicGridKeyboard.java | 17 +++++++++-------- 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/java/src/com/android/inputmethod/keyboard/Keyboard.java b/java/src/com/android/inputmethod/keyboard/Keyboard.java index 801e32528..f646a03c2 100644 --- a/java/src/com/android/inputmethod/keyboard/Keyboard.java +++ b/java/src/com/android/inputmethod/keyboard/Keyboard.java @@ -166,15 +166,6 @@ public class Keyboard { return mSortedKeys; } - public Key getKeyFromOutputText(final String outputText) { - for (final Key key : getSortedKeys()) { - if (outputText.equals(key.getOutputText())) { - return key; - } - } - return null; - } - public Key getKey(final int code) { if (code == Constants.CODE_UNSPECIFIED) { return null; diff --git a/java/src/com/android/inputmethod/keyboard/internal/DynamicGridKeyboard.java b/java/src/com/android/inputmethod/keyboard/internal/DynamicGridKeyboard.java index bf76ca455..397c098ce 100644 --- a/java/src/com/android/inputmethod/keyboard/internal/DynamicGridKeyboard.java +++ b/java/src/com/android/inputmethod/keyboard/internal/DynamicGridKeyboard.java @@ -29,7 +29,6 @@ import com.android.inputmethod.latin.utils.JsonUtils; import java.util.ArrayDeque; import java.util.ArrayList; -import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.List; @@ -148,9 +147,10 @@ public class DynamicGridKeyboard extends Keyboard { private static Key getKeyByCode(final Collection keyboards, final int code) { for (final DynamicGridKeyboard keyboard : keyboards) { - final Key key = keyboard.getKey(code); - if (key != null) { - return key; + for (final Key key : keyboard.getSortedKeys()) { + if (key.getCode() == code) { + return key; + } } } return null; @@ -158,10 +158,11 @@ public class DynamicGridKeyboard extends Keyboard { private static Key getKeyByOutputText(final Collection keyboards, final String outputText) { - for (final DynamicGridKeyboard kbd : keyboards) { - final Key key = kbd.getKeyFromOutputText(outputText); - if (key != null) { - return key; + for (final DynamicGridKeyboard keyboard : keyboards) { + for (final Key key : keyboard.getSortedKeys()) { + if (outputText.equals(key.getOutputText())) { + return key; + } } } return null;