From 18e21d58f7c0b5c5c001835c093221c573a841c4 Mon Sep 17 00:00:00 2001 From: "Tadashi G. Takaoka" Date: Wed, 27 Feb 2013 17:34:03 +0900 Subject: [PATCH] Remove closing method from KeyboardView This is a follow up of Ie00ba827. After the change, the KeyboardView.closing() method does nothing important. Change-Id: I9659ea56ce82a95f8798a4136bf93f164b67fae7 --- java/src/com/android/inputmethod/keyboard/KeyboardView.java | 6 ------ .../com/android/inputmethod/keyboard/MainKeyboardView.java | 2 -- .../android/inputmethod/keyboard/MoreKeysKeyboardView.java | 1 - 3 files changed, 9 deletions(-) diff --git a/java/src/com/android/inputmethod/keyboard/KeyboardView.java b/java/src/com/android/inputmethod/keyboard/KeyboardView.java index 365c35b48..350dc69b2 100644 --- a/java/src/com/android/inputmethod/keyboard/KeyboardView.java +++ b/java/src/com/android/inputmethod/keyboard/KeyboardView.java @@ -635,15 +635,9 @@ public class KeyboardView extends View { invalidate(x, y, x + key.mWidth, y + key.mHeight); } - // TODO: Remove this method. - public void closing() { - mInvalidateAllKeys = true; - } - @Override protected void onDetachedFromWindow() { super.onDetachedFromWindow(); - closing(); freeOffscreenBuffer(); } } diff --git a/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java b/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java index 4d10f0e69..bc27f8553 100644 --- a/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java +++ b/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java @@ -1236,13 +1236,11 @@ public final class MainKeyboardView extends KeyboardView implements PointerTrack mDrawingHandler.cancelAllMessages(); } - @Override public void closing() { dismissAllKeyPreviews(); cancelAllMessages(); onDismissMoreKeysPanel(); mMoreKeysKeyboardCache.clear(); - super.closing(); } /** diff --git a/java/src/com/android/inputmethod/keyboard/MoreKeysKeyboardView.java b/java/src/com/android/inputmethod/keyboard/MoreKeysKeyboardView.java index 9e75f8b8a..0d42ab2fe 100644 --- a/java/src/com/android/inputmethod/keyboard/MoreKeysKeyboardView.java +++ b/java/src/com/android/inputmethod/keyboard/MoreKeysKeyboardView.java @@ -174,7 +174,6 @@ public class MoreKeysKeyboardView extends KeyboardView implements MoreKeysPanel @Override public boolean dismissMoreKeysPanel() { - super.closing(); if (mController == null) return false; return mController.onDismissMoreKeysPanel(); }