From 05113c1847e5c41aab3176eb015aabc2acdc0a51 Mon Sep 17 00:00:00 2001 From: Keisuke Kuroyanagi Date: Wed, 8 Jan 2014 21:02:35 +0900 Subject: [PATCH] Check whether the word is OOV or not for amanatto update. Bug: 11736529 Change-Id: I27973212da7e922b2185dbb4febfb5bb4dfbdcbb --- java/src/com/android/inputmethod/latin/BinaryDictionary.java | 3 +++ .../policyimpl/dictionary/utils/forgetting_curve_utils.cpp | 1 + .../policyimpl/dictionary/utils/forgetting_curve_utils.h | 1 - .../suggest/policyimpl/dictionary/utils/probability_utils.h | 1 + 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/java/src/com/android/inputmethod/latin/BinaryDictionary.java b/java/src/com/android/inputmethod/latin/BinaryDictionary.java index 95ac3e203..708f75a06 100644 --- a/java/src/com/android/inputmethod/latin/BinaryDictionary.java +++ b/java/src/com/android/inputmethod/latin/BinaryDictionary.java @@ -365,6 +365,7 @@ public final class BinaryDictionary extends Dictionary { } public static class LanguageModelParam { + public final String mTargetWord; public final int[] mWord0; public final int[] mWord1; // TODO: this needs to be a list of shortcuts @@ -379,6 +380,7 @@ public final class BinaryDictionary extends Dictionary { // Constructor for unigram. TODO: support shortcuts public LanguageModelParam(final String word, final int unigramProbability, final int timestamp) { + mTargetWord = word; mWord0 = null; mWord1 = StringUtils.toCodePointArray(word); mShortcutTarget = null; @@ -394,6 +396,7 @@ public final class BinaryDictionary extends Dictionary { public LanguageModelParam(final String word0, final String word1, final int unigramProbability, final int bigramProbability, final int timestamp) { + mTargetWord = word1; mWord0 = StringUtils.toCodePointArray(word0); mWord1 = StringUtils.toCodePointArray(word1); mShortcutTarget = null; diff --git a/native/jni/src/suggest/policyimpl/dictionary/utils/forgetting_curve_utils.cpp b/native/jni/src/suggest/policyimpl/dictionary/utils/forgetting_curve_utils.cpp index 4050ad363..d58d25989 100644 --- a/native/jni/src/suggest/policyimpl/dictionary/utils/forgetting_curve_utils.cpp +++ b/native/jni/src/suggest/policyimpl/dictionary/utils/forgetting_curve_utils.cpp @@ -42,6 +42,7 @@ const int ForgettingCurveUtils::DISCARD_LEVEL_ZERO_ENTRY_TIME_STEP_COUNT_THRESHO const ForgettingCurveUtils::ProbabilityTable ForgettingCurveUtils::sProbabilityTable; +// TODO: Revise the logic to decide the initial probability depending on the given probability. /* static */ const HistoricalInfo ForgettingCurveUtils::createUpdatedHistoricalInfo( const HistoricalInfo *const originalHistoricalInfo, const int newProbability, const int timestamp) { diff --git a/native/jni/src/suggest/policyimpl/dictionary/utils/forgetting_curve_utils.h b/native/jni/src/suggest/policyimpl/dictionary/utils/forgetting_curve_utils.h index 6ac8dc528..b37353455 100644 --- a/native/jni/src/suggest/policyimpl/dictionary/utils/forgetting_curve_utils.h +++ b/native/jni/src/suggest/policyimpl/dictionary/utils/forgetting_curve_utils.h @@ -26,7 +26,6 @@ namespace latinime { class DictionaryHeaderStructurePolicy; -// TODO: Quit using bigram probability to indicate the delta. class ForgettingCurveUtils { public: static const int MAX_UNIGRAM_COUNT; diff --git a/native/jni/src/suggest/policyimpl/dictionary/utils/probability_utils.h b/native/jni/src/suggest/policyimpl/dictionary/utils/probability_utils.h index 21fe355b8..14fdf53cb 100644 --- a/native/jni/src/suggest/policyimpl/dictionary/utils/probability_utils.h +++ b/native/jni/src/suggest/policyimpl/dictionary/utils/probability_utils.h @@ -23,6 +23,7 @@ namespace latinime { +// TODO: Quit using bigram probability to indicate the delta. class ProbabilityUtils { public: static AK_FORCE_INLINE int backoff(const int unigramProbability) {