Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
		
			
				
	
	
		
			165 lines
		
	
	
	
		
			3.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			165 lines
		
	
	
	
		
			3.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2020 The Macaron Authors
 | |
| // Copyright 2020 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package middlewares
 | |
| 
 | |
| import (
 | |
| 	"net/http"
 | |
| 	"net/url"
 | |
| 	"time"
 | |
| 
 | |
| 	"code.gitea.io/gitea/modules/setting"
 | |
| )
 | |
| 
 | |
| // MaxAge sets the maximum age for a provided cookie
 | |
| func MaxAge(maxAge int) func(*http.Cookie) {
 | |
| 	return func(c *http.Cookie) {
 | |
| 		c.MaxAge = maxAge
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Path sets the path for a provided cookie
 | |
| func Path(path string) func(*http.Cookie) {
 | |
| 	return func(c *http.Cookie) {
 | |
| 		c.Path = path
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Domain sets the domain for a provided cookie
 | |
| func Domain(domain string) func(*http.Cookie) {
 | |
| 	return func(c *http.Cookie) {
 | |
| 		c.Domain = domain
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Secure sets the secure setting for a provided cookie
 | |
| func Secure(secure bool) func(*http.Cookie) {
 | |
| 	return func(c *http.Cookie) {
 | |
| 		c.Secure = secure
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // HTTPOnly sets the HttpOnly setting for a provided cookie
 | |
| func HTTPOnly(httpOnly bool) func(*http.Cookie) {
 | |
| 	return func(c *http.Cookie) {
 | |
| 		c.HttpOnly = httpOnly
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Expires sets the expires and rawexpires for a provided cookie
 | |
| func Expires(expires time.Time) func(*http.Cookie) {
 | |
| 	return func(c *http.Cookie) {
 | |
| 		c.Expires = expires
 | |
| 		c.RawExpires = expires.Format(time.UnixDate)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // SameSite sets the SameSite for a provided cookie
 | |
| func SameSite(sameSite http.SameSite) func(*http.Cookie) {
 | |
| 	return func(c *http.Cookie) {
 | |
| 		c.SameSite = sameSite
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // NewCookie creates a cookie
 | |
| func NewCookie(name, value string, maxAge int) *http.Cookie {
 | |
| 	return &http.Cookie{
 | |
| 		Name:     name,
 | |
| 		Value:    value,
 | |
| 		HttpOnly: true,
 | |
| 		Path:     setting.SessionConfig.CookiePath,
 | |
| 		Domain:   setting.SessionConfig.Domain,
 | |
| 		MaxAge:   maxAge,
 | |
| 		Secure:   setting.SessionConfig.Secure,
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // SetCookie set the cookies
 | |
| // TODO: Copied from gitea.com/macaron/macaron and should be improved after macaron removed.
 | |
| func SetCookie(resp http.ResponseWriter, name string, value string, others ...interface{}) {
 | |
| 	cookie := http.Cookie{}
 | |
| 	cookie.Name = name
 | |
| 	cookie.Value = url.QueryEscape(value)
 | |
| 
 | |
| 	if len(others) > 0 {
 | |
| 		switch v := others[0].(type) {
 | |
| 		case int:
 | |
| 			cookie.MaxAge = v
 | |
| 		case int64:
 | |
| 			cookie.MaxAge = int(v)
 | |
| 		case int32:
 | |
| 			cookie.MaxAge = int(v)
 | |
| 		case func(*http.Cookie):
 | |
| 			v(&cookie)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	cookie.Path = "/"
 | |
| 	if len(others) > 1 {
 | |
| 		if v, ok := others[1].(string); ok && len(v) > 0 {
 | |
| 			cookie.Path = v
 | |
| 		} else if v, ok := others[1].(func(*http.Cookie)); ok {
 | |
| 			v(&cookie)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	if len(others) > 2 {
 | |
| 		if v, ok := others[2].(string); ok && len(v) > 0 {
 | |
| 			cookie.Domain = v
 | |
| 		} else if v, ok := others[1].(func(*http.Cookie)); ok {
 | |
| 			v(&cookie)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	if len(others) > 3 {
 | |
| 		switch v := others[3].(type) {
 | |
| 		case bool:
 | |
| 			cookie.Secure = v
 | |
| 		case func(*http.Cookie):
 | |
| 			v(&cookie)
 | |
| 		default:
 | |
| 			if others[3] != nil {
 | |
| 				cookie.Secure = true
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	if len(others) > 4 {
 | |
| 		if v, ok := others[4].(bool); ok && v {
 | |
| 			cookie.HttpOnly = true
 | |
| 		} else if v, ok := others[1].(func(*http.Cookie)); ok {
 | |
| 			v(&cookie)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	if len(others) > 5 {
 | |
| 		if v, ok := others[5].(time.Time); ok {
 | |
| 			cookie.Expires = v
 | |
| 			cookie.RawExpires = v.Format(time.UnixDate)
 | |
| 		} else if v, ok := others[1].(func(*http.Cookie)); ok {
 | |
| 			v(&cookie)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	if len(others) > 6 {
 | |
| 		for _, other := range others[6:] {
 | |
| 			if v, ok := other.(func(*http.Cookie)); ok {
 | |
| 				v(&cookie)
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	resp.Header().Add("Set-Cookie", cookie.String())
 | |
| }
 | |
| 
 | |
| // GetCookie returns given cookie value from request header.
 | |
| func GetCookie(req *http.Request, name string) string {
 | |
| 	cookie, err := req.Cookie(name)
 | |
| 	if err != nil {
 | |
| 		return ""
 | |
| 	}
 | |
| 	val, _ := url.QueryUnescape(cookie.Value)
 | |
| 	return val
 | |
| }
 |