lavender-legacy/gitea
7
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
gitea/modules/git
History
zeripath 148a417774
Prevent off-by-one error on comments on newly appended lines (#18029) (#18035) 
* Prevent off-by-one error on comments on newly appended lines (#18029)

Backport #18029

There was a bug in CutDiffAroundLine whereby if a file without a terminal new line
has a patch which appends lines to it and a comment is placed on one of those lines
the comment diff will be a line out of place.

This fixes CutDiffAroundLine to simply ignore the missing terminal newline - however,
we should really improve this rendering to add a marker to say that there was a
previously missing terminal newline.

Fix #17875

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Apply suggestions from code review

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2021-12-20 11:38:58 -05:00
..
pipeline Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tests/repos Fix webhook commits wrong hash on HEAD reset (#16283) 2021-06-30 19:49:06 +02:00
batch_reader.go Prevent hang in git cat-file if the repository is not a valid repository (Partial #17991) (#17992) 2021-12-17 10:08:00 +08:00
blame.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
blame_test.go
blob.go Read expected buffer size (#17409) (#17430) 2021-10-25 17:46:56 +01:00
blob_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
blob_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
blob_test.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
command.go Limit stdout tracelog to actual stdout (#16258) 2021-06-26 13:47:56 +01:00
command_test.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
commit.go Fix modified files list in webhooks when there is a space (#16288) 2021-07-02 21:23:37 +02:00
commit_convert_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
commit_info.go
commit_info_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
commit_info_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
commit_info_test.go Make commit info cancelable (#16032) 2021-06-06 19:44:58 -04:00
commit_reader.go Tagger can be empty, as can Commit and Author - tolerate this (#15835) 2021-05-12 01:11:42 -04:00
commit_test.go Fix modified files list in webhooks when there is a space (#16288) 2021-07-02 21:23:37 +02:00
diff.go Prevent off-by-one error on comments on newly appended lines (#18029) (#18035) 2021-12-20 11:38:58 -05:00
diff_test.go Prevent off-by-one error on comments on newly appended lines (#18029) (#18035) 2021-12-20 11:38:58 -05:00
error.go Fix 500 Error with branch and tag sharing the same name #15592 (#16040) 2021-06-23 17:08:26 -04:00
git.go Disable core.protectNTFS (#17300) (#17302) 2021-10-13 23:02:45 +03:00
git_test.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
hook.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
last_commit_cache.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
last_commit_cache_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
last_commit_cache_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
lfs.go Let package git depend on setting but not opposite (#15241) 2021-06-26 13:28:55 +02:00
log_name_status.go Fix missing close in WalkGitLog (#17008) (#17009) 2021-09-10 17:46:06 +08:00
notes.go
notes_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
notes_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
notes_test.go Change the implementation of the go-git version of GetNote to mirror the non go-git version when passed a non-existent commit (#16658) (#16659) 2021-08-09 20:24:31 +01:00
parse_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
parse_gogit_test.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
parse_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
parse_nogogit_test.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
README.md
ref.go
remote.go Add push to remote mirror repository (#15157) 2021-06-14 19:20:43 +02:00
repo.go Fix 500 Error with branch and tag sharing the same name #15592 (#16040) 2021-06-23 17:08:26 -04:00
repo_archive.go Rework repository archive (#14723) 2021-06-23 17:12:38 -04:00
repo_attribute.go
repo_base_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_base_nogogit.go Prevent hang in git cat-file if the repository is not a valid repository (Partial #17991) (#17992) 2021-12-17 10:08:00 +08:00
repo_blame.go
repo_blob.go
repo_blob_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_blob_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_blob_test.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
repo_branch.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
repo_branch_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_branch_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_branch_test.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
repo_commit.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repo_commit_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_commit_nogogit.go Prevent hang in git cat-file if the repository is not a valid repository (Partial #17991) (#17992) 2021-12-17 10:08:00 +08:00
repo_commit_test.go Fix webhook commits wrong hash on HEAD reset (#16283) 2021-06-30 19:49:06 +02:00
repo_commitgraph_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_compare.go Restore detection of branches are equal on compare page (#14586) 2021-02-16 16:39:45 +01:00
repo_compare_test.go
repo_gpg.go
repo_hook.go
repo_index.go
repo_language_stats.go
repo_language_stats_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_language_stats_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_object.go
repo_ref.go
repo_ref_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_ref_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_ref_test.go
repo_stats.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repo_stats_test.go
repo_tag.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
repo_tag_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_tag_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_tag_test.go Create tag on ui (#13467) 2021-02-28 19:57:45 +00:00
repo_test.go Tests should use test files (#15801) 2021-05-09 17:20:33 +02:00
repo_tree.go
repo_tree_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_tree_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
sha1.go
sha1_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
sha1_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
signature.go
signature_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
signature_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
submodule.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
submodule_test.go
tag.go Tagger can be empty, as can Commit and Author - tolerate this (#15835) 2021-05-12 01:11:42 -04:00
tag_test.go Fix git.parseTagData (#14105) 2020-12-22 21:44:25 +01:00
tree.go Add TestPrepareWikiFileName (#16487) (#16498) 2021-07-21 03:37:00 +01:00
tree_blob.go
tree_blob_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_blob_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_entry.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
tree_entry_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_entry_mode.go
tree_entry_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_entry_test.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
utils.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
utils_test.go

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.