Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
		
			
				
	
	
		
			289 lines
		
	
	
	
		
			7.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			289 lines
		
	
	
	
		
			7.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2016 The Gogs Authors. All rights reserved.
 | |
| // Copyright 2020 The Gitea Authors.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package repo
 | |
| 
 | |
| import (
 | |
| 	"net/http"
 | |
| 	"strconv"
 | |
| 	"time"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models"
 | |
| 	"code.gitea.io/gitea/modules/context"
 | |
| 	"code.gitea.io/gitea/modules/convert"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 	"code.gitea.io/gitea/modules/timeutil"
 | |
| 	"code.gitea.io/gitea/modules/web"
 | |
| 	"code.gitea.io/gitea/routers/api/v1/utils"
 | |
| )
 | |
| 
 | |
| // ListMilestones list milestones for a repository
 | |
| func ListMilestones(ctx *context.APIContext) {
 | |
| 	// swagger:operation GET /repos/{owner}/{repo}/milestones issue issueGetMilestonesList
 | |
| 	// ---
 | |
| 	// summary: Get all of a repository's opened milestones
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: owner
 | |
| 	//   in: path
 | |
| 	//   description: owner of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: repo
 | |
| 	//   in: path
 | |
| 	//   description: name of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: state
 | |
| 	//   in: query
 | |
| 	//   description: Milestone state, Recognised values are open, closed and all. Defaults to "open"
 | |
| 	//   type: string
 | |
| 	// - name: name
 | |
| 	//   in: query
 | |
| 	//   description: filter by milestone name
 | |
| 	//   type: string
 | |
| 	// - name: page
 | |
| 	//   in: query
 | |
| 	//   description: page number of results to return (1-based)
 | |
| 	//   type: integer
 | |
| 	// - name: limit
 | |
| 	//   in: query
 | |
| 	//   description: page size of results
 | |
| 	//   type: integer
 | |
| 	// responses:
 | |
| 	//   "200":
 | |
| 	//     "$ref": "#/responses/MilestoneList"
 | |
| 
 | |
| 	milestones, err := models.GetMilestones(models.GetMilestonesOption{
 | |
| 		ListOptions: utils.GetListOptions(ctx),
 | |
| 		RepoID:      ctx.Repo.Repository.ID,
 | |
| 		State:       api.StateType(ctx.Query("state")),
 | |
| 		Name:        ctx.Query("name"),
 | |
| 	})
 | |
| 	if err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "GetMilestones", err)
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	apiMilestones := make([]*api.Milestone, len(milestones))
 | |
| 	for i := range milestones {
 | |
| 		apiMilestones[i] = convert.ToAPIMilestone(milestones[i])
 | |
| 	}
 | |
| 	ctx.JSON(http.StatusOK, &apiMilestones)
 | |
| }
 | |
| 
 | |
| // GetMilestone get a milestone for a repository by ID and if not available by name
 | |
| func GetMilestone(ctx *context.APIContext) {
 | |
| 	// swagger:operation GET /repos/{owner}/{repo}/milestones/{id} issue issueGetMilestone
 | |
| 	// ---
 | |
| 	// summary: Get a milestone
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: owner
 | |
| 	//   in: path
 | |
| 	//   description: owner of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: repo
 | |
| 	//   in: path
 | |
| 	//   description: name of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: the milestone to get, identified by ID and if not available by name
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// responses:
 | |
| 	//   "200":
 | |
| 	//     "$ref": "#/responses/Milestone"
 | |
| 
 | |
| 	milestone := getMilestoneByIDOrName(ctx)
 | |
| 	if ctx.Written() {
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	ctx.JSON(http.StatusOK, convert.ToAPIMilestone(milestone))
 | |
| }
 | |
| 
 | |
| // CreateMilestone create a milestone for a repository
 | |
| func CreateMilestone(ctx *context.APIContext) {
 | |
| 	// swagger:operation POST /repos/{owner}/{repo}/milestones issue issueCreateMilestone
 | |
| 	// ---
 | |
| 	// summary: Create a milestone
 | |
| 	// consumes:
 | |
| 	// - application/json
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: owner
 | |
| 	//   in: path
 | |
| 	//   description: owner of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: repo
 | |
| 	//   in: path
 | |
| 	//   description: name of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: body
 | |
| 	//   in: body
 | |
| 	//   schema:
 | |
| 	//     "$ref": "#/definitions/CreateMilestoneOption"
 | |
| 	// responses:
 | |
| 	//   "201":
 | |
| 	//     "$ref": "#/responses/Milestone"
 | |
| 	form := web.GetForm(ctx).(*api.CreateMilestoneOption)
 | |
| 
 | |
| 	if form.Deadline == nil {
 | |
| 		defaultDeadline, _ := time.ParseInLocation("2006-01-02", "9999-12-31", time.Local)
 | |
| 		form.Deadline = &defaultDeadline
 | |
| 	}
 | |
| 
 | |
| 	milestone := &models.Milestone{
 | |
| 		RepoID:       ctx.Repo.Repository.ID,
 | |
| 		Name:         form.Title,
 | |
| 		Content:      form.Description,
 | |
| 		DeadlineUnix: timeutil.TimeStamp(form.Deadline.Unix()),
 | |
| 	}
 | |
| 
 | |
| 	if form.State == "closed" {
 | |
| 		milestone.IsClosed = true
 | |
| 		milestone.ClosedDateUnix = timeutil.TimeStampNow()
 | |
| 	}
 | |
| 
 | |
| 	if err := models.NewMilestone(milestone); err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "NewMilestone", err)
 | |
| 		return
 | |
| 	}
 | |
| 	ctx.JSON(http.StatusCreated, convert.ToAPIMilestone(milestone))
 | |
| }
 | |
| 
 | |
| // EditMilestone modify a milestone for a repository by ID and if not available by name
 | |
| func EditMilestone(ctx *context.APIContext) {
 | |
| 	// swagger:operation PATCH /repos/{owner}/{repo}/milestones/{id} issue issueEditMilestone
 | |
| 	// ---
 | |
| 	// summary: Update a milestone
 | |
| 	// consumes:
 | |
| 	// - application/json
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: owner
 | |
| 	//   in: path
 | |
| 	//   description: owner of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: repo
 | |
| 	//   in: path
 | |
| 	//   description: name of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: the milestone to edit, identified by ID and if not available by name
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: body
 | |
| 	//   in: body
 | |
| 	//   schema:
 | |
| 	//     "$ref": "#/definitions/EditMilestoneOption"
 | |
| 	// responses:
 | |
| 	//   "200":
 | |
| 	//     "$ref": "#/responses/Milestone"
 | |
| 	form := web.GetForm(ctx).(*api.EditMilestoneOption)
 | |
| 	milestone := getMilestoneByIDOrName(ctx)
 | |
| 	if ctx.Written() {
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	if len(form.Title) > 0 {
 | |
| 		milestone.Name = form.Title
 | |
| 	}
 | |
| 	if form.Description != nil {
 | |
| 		milestone.Content = *form.Description
 | |
| 	}
 | |
| 	if form.Deadline != nil && !form.Deadline.IsZero() {
 | |
| 		milestone.DeadlineUnix = timeutil.TimeStamp(form.Deadline.Unix())
 | |
| 	}
 | |
| 
 | |
| 	var oldIsClosed = milestone.IsClosed
 | |
| 	if form.State != nil {
 | |
| 		milestone.IsClosed = *form.State == string(api.StateClosed)
 | |
| 	}
 | |
| 
 | |
| 	if err := models.UpdateMilestone(milestone, oldIsClosed); err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "UpdateMilestone", err)
 | |
| 		return
 | |
| 	}
 | |
| 	ctx.JSON(http.StatusOK, convert.ToAPIMilestone(milestone))
 | |
| }
 | |
| 
 | |
| // DeleteMilestone delete a milestone for a repository by ID and if not available by name
 | |
| func DeleteMilestone(ctx *context.APIContext) {
 | |
| 	// swagger:operation DELETE /repos/{owner}/{repo}/milestones/{id} issue issueDeleteMilestone
 | |
| 	// ---
 | |
| 	// summary: Delete a milestone
 | |
| 	// parameters:
 | |
| 	// - name: owner
 | |
| 	//   in: path
 | |
| 	//   description: owner of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: repo
 | |
| 	//   in: path
 | |
| 	//   description: name of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: the milestone to delete, identified by ID and if not available by name
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// responses:
 | |
| 	//   "204":
 | |
| 	//     "$ref": "#/responses/empty"
 | |
| 
 | |
| 	m := getMilestoneByIDOrName(ctx)
 | |
| 	if ctx.Written() {
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	if err := models.DeleteMilestoneByRepoID(ctx.Repo.Repository.ID, m.ID); err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "DeleteMilestoneByRepoID", err)
 | |
| 		return
 | |
| 	}
 | |
| 	ctx.Status(http.StatusNoContent)
 | |
| }
 | |
| 
 | |
| // getMilestoneByIDOrName get milestone by ID and if not available by name
 | |
| func getMilestoneByIDOrName(ctx *context.APIContext) *models.Milestone {
 | |
| 	mile := ctx.Params(":id")
 | |
| 	mileID, _ := strconv.ParseInt(mile, 0, 64)
 | |
| 
 | |
| 	if mileID != 0 {
 | |
| 		milestone, err := models.GetMilestoneByRepoID(ctx.Repo.Repository.ID, mileID)
 | |
| 		if err == nil {
 | |
| 			return milestone
 | |
| 		} else if !models.IsErrMilestoneNotExist(err) {
 | |
| 			ctx.Error(http.StatusInternalServerError, "GetMilestoneByRepoID", err)
 | |
| 			return nil
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	milestone, err := models.GetMilestoneByRepoIDANDName(ctx.Repo.Repository.ID, mile)
 | |
| 	if err != nil {
 | |
| 		if models.IsErrMilestoneNotExist(err) {
 | |
| 			ctx.NotFound()
 | |
| 			return nil
 | |
| 		}
 | |
| 		ctx.Error(http.StatusInternalServerError, "GetMilestoneByRepoID", err)
 | |
| 		return nil
 | |
| 	}
 | |
| 
 | |
| 	return milestone
 | |
| }
 |