64133126cd
Update golangci-lint to version 1.31.0 ( #13102 )
...
This PR updates golangci-lint to the latest version 1.31.0.
The upgrade introduced a new check for which I've fixed or disabled most cases.
Signed-off-by: kolaente <k@knt.li>
2020-10-11 21:27:20 +01:00
7eb8460132
Fix attachments list in edit comment ( #13036 )
...
#11141 broke the appearance of dropzone attachments when editting
comments causing poorly updating lists.
This PR fixes this.
Fix #12583
Signed-off-by: Andrew Thornton art27@cantab.net
2020-10-11 00:49:59 +01:00
cda44750cb
Attachments: Add extension support, allow all types for releases ( #12465 )
...
* Attachments: Add extension support, allow all types for releases
- Add support for file extensions, matching the `accept` attribute of `<input type="file">`
- Add support for type wildcard mime types, e.g. `image/*`
- Create repository.release.ALLOWED_TYPES setting (default unrestricted)
- Change default for attachment.ALLOWED_TYPES to a list of extensions
- Split out POST /attachments into two endpoints for issue/pr and
releases to prevent circumvention of allowed types check
Fixes: https://github.com/go-gitea/gitea/pull/10172
Fixes: https://github.com/go-gitea/gitea/issues/7266
Fixes: https://github.com/go-gitea/gitea/pull/12460
Ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#Unique_file_type_specifiers
* rename function
* extract GET routes out of RepoMustNotBeArchived
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-10-05 01:49:33 -04:00
2d0b90c967
Fix upload file type check ( #7890 )
...
* fix upload file type check
* make the function simple and added tests
* Update comment as per @silverwind
2019-08-17 13:10:17 +03:00
f369788347
Refactor filetype is not allowed errors ( #7309 )
2019-07-06 22:25:05 -04:00
kolaente
zeripath
silverwind
Lunny Xiao
Antoine GIRARD