0823791d17
Recover panic in orgmode.Render if bad orgfile ( #4982 ) ( #5903 )
...
This PR protects against the panic referred to in chaseadmsio/goorgeous#82
by recovering from the panic and just returning the raw bytes if
there is an error.
Signed-off-by: Andrew Thornton <art27@cantab.net>
2019-01-30 17:17:43 -05:00
ca00ca8ee4
Provide better panic handling ( #5902 )
...
This PR gitea'ises the macaron.Recovery() handler meaning that in
the event of panic we get proper gitea 500 pages and the stacktrace
is logged with the gitea logger.
Signed-off-by: Andrew Thornton <art27@cantab.net>
2019-01-30 17:00:00 -05:00
0f295ababa
Only allow local login if password is non-empty ( #5906 )
2019-01-30 23:18:54 +02:00
80098bd752
Fix go-get URL generation ( #5905 )
2019-01-30 21:04:19 +00:00
57a69ef277
don't allow pull requests to be created on an archived repository ( #5883 )
...
* don't allow pull requests to be created on an archived repository
Also disable the "PR" button if the repo is archived
* Refuse creating an issue/PR via API calls too
2019-01-30 12:20:40 -05:00
6dc2f401c9
Don't discard the value of DISABLE_REGULAR_ORG_CREATION ( #5886 )
...
* Consider the configuration value of DISABLE_REGULAR_ORG_CREATION when
creating a user
2019-01-30 12:04:14 -05:00
7933a950d0
respect value of REQUIRE_SIGNIN_VIEW ( #5901 )
2019-01-30 11:45:48 -05:00
fada6968a8
Fix new release creation API to allow empty target ( #5870 )
...
* Fix new release creation API to allow empty target
* Add more test cases
* Update swagger
2019-01-30 11:33:00 -05:00
8b5f6ced22
if repo does not exist, show a 404 not a 500 ( #5900 )
2019-01-30 11:13:39 -05:00
a967cf9e99
UI: Correct footer height if screen-width is to small ( fixes #5878 ) ( #5889 ) ( #5889 )
2019-01-29 19:45:08 -05:00
16678f5255
fix compare button on upstream repo leading to 404 ( #5877 )
2019-01-29 18:49:07 -05:00
c62c0b669a
UI: Change GPG Validation colors and remove inline CSS; fixes #5404 ( #5896 )
2019-01-29 18:11:53 -05:00
2569363204
Also ensure the repo is loaded ( #5895 )
...
Signed-off-by: Andrew Thornton <art27@cantab.net>
2019-01-29 22:43:40 +00:00
002e898bcf
[skip ci] Updated translations via Crowdin
2019-01-29 21:28:45 +00:00
036964b4a7
Ensure issue.Poster is loaded in mailIssueCommentToParticipants ( #5891 )
...
Previous code could potentially dereference nil - this PR ensures
that the poster is loaded before dereferencing it.
Signed-off-by: Andrew Thornton <art27@cantab.net>
2019-01-29 16:26:17 -05:00
8917d66571
Add migration test ( #5773 )
...
* Add migration test
This commit adds a simple migration test for v1.5.3, v1.6.4 and v1.7.0-rc3
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Automigrate based on available dbs
* remove old ini file
* Standardise the dialect names
2019-01-28 11:18:52 -05:00
bc748f205a
[skip ci] Updated translations via Crowdin
2019-01-28 15:55:40 +00:00
573650877c
Fix wrong URL to download link. ( #5881 )
...
* Fix wrong URL to download link.
The link does not contain trailing slash and cause error page displayed.
* Update version
2019-01-28 10:53:16 -05:00
3568d426fe
New Issue ?body= query ( #5851 )
...
* New Issue ?body= query
* Override issue template with body query
* Add documentation for issue body query
2019-01-28 10:23:59 -05:00
7461c5a75f
Fix "pulls.blocked_by_approvals" text ( #5879 )
2019-01-28 10:05:20 -05:00
56415fa2fc
[skip ci] Updated translations via Crowdin
2019-01-28 14:16:11 +00:00
bf47f70c3b
API: Fix null pointer in attempt to Sudo if not logged in ( #5872 )
...
Signed-off-by: Andrew Thornton <art27@cantab.net>
2019-01-28 14:13:59 +00:00
5f4a40c4a3
Revert #3711 overwrite of only show "No Description" to repo admins #2167 ( #5836 )
...
Revert #3711 overwrite of only show "No Description" to repo admins #2167 and add tests to prevent accidental overwrite again.
2019-01-27 21:13:15 +00:00
182a6d6885
Fix wording of #5858 issue.review.reject string ( #5869 )
...
As per @lafriks comment this should be: requested changes
Signed-off-by: Andrew Thornton <art27@cantab.net>
2019-01-27 19:39:49 +02:00
34a1c4c514
[skip ci] Updated translations via Crowdin
2019-01-27 11:31:56 +00:00
7e8242ddb1
Fix an error while adding a dependency via UI. ( #5862 )
...
Fixes : #5783
2019-01-27 13:31:40 +02:00
2d8520d039
[skip ci] Updated translations via Crowdin
2019-01-27 09:27:05 +00:00
84076211b3
Config option to disable automatic repo watching ( #5852 )
...
Add a new config option to enable / disable the automatic watching of
repos for new repositories and if a user is added to a team.
Fixes #653
Signed-off-by: Sebastian Sauer <sauer.sebastian@gmail.com>
2019-01-27 09:25:21 +00:00
b8a81cb1b8
Rename reject to 'request changes' ( #5858 )
...
* remame reject to 'request changes
* make usee of requested changes in issue's view content
2019-01-26 12:20:56 -05:00
a757920f4e
Fix failing migration v67 ( #5849 )
...
Fixes #5848
2019-01-26 14:50:36 +00:00
8510ac2687
Fix MinInterval ( #5856 )
...
Fixes #5847
2019-01-26 08:26:23 +00:00
ac766fe3de
[skip ci] Updated translations via Crowdin
2019-01-26 00:17:00 +00:00
8656a3c62d
Move input fields to add members to a team and repos to a team ( #5853 )
...
Move input fields to the top so no scrolling is needed to add
new members / repos to a team.
Signed-off-by: Sebastian Sauer <sauer.sebastian@gmail.com>
2019-01-25 19:14:35 -05:00
d663930023
fix delete correct temp directory ( #5839 )
2019-01-25 02:54:09 -05:00
6b0c2e9e35
update swagger for release API pagination ( #5841 )
2019-01-25 09:10:50 +02:00
892bfd0b19
improve the releases api paging ( #5831 )
...
* improve the releases api paging
* add max limit on API paging
2019-01-24 20:59:27 +02:00
9a137faaaf
Added docs for the tree api ( #5834 )
...
* Added docs for the tree api
* Added missing response definition
* Fixed swagger docs
2019-01-24 13:13:30 -05:00
62da3bee1a
[skip ci] Updated translations via Crowdin
2019-01-24 15:23:19 +00:00
d6c229cdbe
Include Go toolchain to --version ( #5830 )
...
* Include Go version
* fix import order
2019-01-24 10:22:51 -05:00
4aa2f4f45f
[skip ci] Updated translations via Crowdin
2019-01-24 14:22:36 +00:00
44371b96f5
Ensure valid git author names passed in signatures ( #5774 )
...
* Ensure valid git author names passed in signatures
Fix #5772 - Git author names are not allowed to include `\n` `<` or `>` and
must not be empty. Ensure that the name passed in a signature is valid.
* Account for pathologically named external users
LDAP and the like usernames are not checked in the same way that users who signup are.
Therefore just ensure that user names are also git safe and if totally pathological -
Set them to "user-$UID"
* Add Tests and adjust test users
Make our testcases a little more pathological so that we be sure that integration
tests have a chance to spot these cases.
Signed-off-by: Andrew Thornton <art27@cantab.net>
2019-01-24 16:12:17 +02:00
cd83c2ca05
Fix topics saving internal error and disable for archived repos ( #5821 )
2019-01-24 12:22:27 +02:00
ec31ee1c1c
Make sure .git/info is created before generating .git/info/sparse-che… ( #5825 )
...
* Make sure .git/info is created before generating .git/info/sparse-checkout
* fix permissions
2019-01-24 09:43:37 +02:00
88aa70bab9
Remove tidb reference from docs ( #5823 )
...
* Remove tidb reference from docs
* Update from-source.fr-fr.md
* Update from-source.zh-cn.md
* Update from-source.zh-tw.md
2019-01-24 09:12:42 +02:00
386e5312a4
When creating new repository fsck option should be enabled ( #5817 )
2019-01-23 22:26:18 -05:00
3b364029f7
Fix TLS errors when using acme/autocert for local connections ( #5820 )
2019-01-23 19:47:54 -05:00
331c9120e8
Request for public keys only if LDAP attribute is set ( #5816 )
...
* Update go-ldap dependency
* Request for public keys only if attribute is set
2019-01-24 01:25:33 +02:00
1b90692844
New API routes added ( #5594 )
...
* New API routes added
* Comments added
* Build fix
* swagger_v1_json.tmpl without new line character
* Typo fix
* Code review changes
* Code review changes
* Add copyright
* Add copyright
* Add copyright
* Update per @lafriks feedback
* Update org.go
* Update user.go
* Update user.go
* make fmt
2019-01-23 17:30:19 -05:00
b9f87376a2
[skip ci] Updated translations via Crowdin
2019-01-23 20:11:56 +00:00
904188ce9c
Adapt documentation to renamed ENABLE_SWAGGER option ( #5811 )
...
Updates documentation to account for the renamed ENABLE_SWAGGER_ENDPOINT from #3572 (commit a74426d631
2019-01-23 20:09:18 +00:00
zeripath
Lauris BH
Lanre Adelowo
EpicCoder
GiteaBot
vee w
kekero
Gabriel Silva Simões
Harshit Bansal
sebastian-sauer
Jakub Arbet
yasuokav
Lunny Xiao
kolaente
Antoine GIRARD
Mura Li
techknowlogick
Joona Hoikkala
Shashvat Kedia
Peter Colberg