Ignore empty avatars in v115.go (#9520)

* Ignore empty avatars

* fixup! Ignore empty avatars
release/v1.15
zeripath 2019-12-27 22:57:38 +00:00 committed by Lauris BH
parent 4acca9d2e8
commit e64880ef07
1 changed files with 4 additions and 1 deletions

View File

@ -47,7 +47,10 @@ func renameExistingUserAvatarName(x *xorm.Engine) error {
for _, user := range users {
oldAvatar := user.Avatar
if _, err := os.Stat(filepath.Join(setting.AvatarUploadPath, oldAvatar)); err != nil {
if stat, err := os.Stat(filepath.Join(setting.AvatarUploadPath, oldAvatar)); err != nil || !stat.Mode().IsRegular() {
if err == nil {
err = fmt.Errorf("Error: \"%s\" is not a regular file", oldAvatar)
}
log.Warn("[user: %s] os.Stat: %v", user.LowerName, err)
// avatar doesn't exist in the storage
// no need to move avatar and update database