Fix plain readme didn't render correctly on repo home page (#2705)
* fix plain readme didn't render correctly on repo home page * fix missing render * remove unused template variables
This commit is contained in:
		
							parent
							
								
									c7f4f07765
								
							
						
					
					
						commit
						a75d5c72bb
					
				
					 2 changed files with 9 additions and 14 deletions
				
			
		|  | @ -93,16 +93,12 @@ func renderDirectory(ctx *context.Context, treeLink string) { | |||
| 		if isTextFile { | ||||
| 			d, _ := ioutil.ReadAll(dataRc) | ||||
| 			buf = append(buf, d...) | ||||
| 			newbuf := markup.Render(readmeFile.Name(), buf, treeLink, ctx.Repo.Repository.ComposeMetas()) | ||||
| 			if newbuf != nil { | ||||
| 				ctx.Data["IsMarkup"] = true | ||||
| 			ctx.Data["IsRenderedHTML"] = true | ||||
| 			if markup.Type(readmeFile.Name()) != "" { | ||||
| 				ctx.Data["FileContent"] = string(markup.Render(readmeFile.Name(), buf, treeLink, ctx.Repo.Repository.ComposeMetas())) | ||||
| 			} else { | ||||
| 				// FIXME This is the only way to show non-markdown files
 | ||||
| 				// instead of a broken "View Raw" link
 | ||||
| 				ctx.Data["IsMarkup"] = false | ||||
| 				newbuf = bytes.Replace(buf, []byte("\n"), []byte(`<br>`), -1) | ||||
| 				ctx.Data["FileContent"] = string(bytes.Replace(buf, []byte("\n"), []byte(`<br>`), -1)) | ||||
| 			} | ||||
| 			ctx.Data["FileContent"] = string(newbuf) | ||||
| 		} | ||||
| 	} | ||||
| 
 | ||||
|  | @ -195,14 +191,13 @@ func renderFile(ctx *context.Context, entry *git.TreeEntry, treeLink, rawLink st | |||
| 		d, _ := ioutil.ReadAll(dataRc) | ||||
| 		buf = append(buf, d...) | ||||
| 
 | ||||
| 		tp := markup.Type(blob.Name()) | ||||
| 		isSupportedMarkup := tp != "" | ||||
| 		ctx.Data["IsMarkup"] = isSupportedMarkup | ||||
| 		readmeExist := markup.IsReadmeFile(blob.Name()) | ||||
| 		ctx.Data["ReadmeExist"] = readmeExist | ||||
| 		if isSupportedMarkup { | ||||
| 		if markup.Type(blob.Name()) != "" { | ||||
| 			ctx.Data["IsRenderedHTML"] = true | ||||
| 			ctx.Data["FileContent"] = string(markup.Render(blob.Name(), buf, path.Dir(treeLink), ctx.Repo.Repository.ComposeMetas())) | ||||
| 		} else if readmeExist { | ||||
| 			ctx.Data["IsRenderedHTML"] = true | ||||
| 			ctx.Data["FileContent"] = string(bytes.Replace(buf, []byte("\n"), []byte(`<br>`), -1)) | ||||
| 		} else { | ||||
| 			// Building code view blocks with line number on server side.
 | ||||
|  |  | |||
|  | @ -36,8 +36,8 @@ | |||
| 		{{end}} | ||||
| 	</h4> | ||||
| 	<div class="ui attached table segment"> | ||||
| 		<div class="file-view {{if .IsMarkup}}markdown{{else if .IsTextFile}}code-view{{end}} has-emoji"> | ||||
| 			{{if .IsMarkup}} | ||||
| 		<div class="file-view {{if .IsRenderedHTML}}markdown{{else if .IsTextFile}}code-view{{end}} has-emoji"> | ||||
| 			{{if .IsRenderedHTML}} | ||||
| 				{{if .FileContent}}{{.FileContent | Str2html}}{{end}} | ||||
| 			{{else if not .IsTextFile}} | ||||
| 				<div class="view-raw ui center"> | ||||
|  |  | |||
		Loading…
	
		Reference in a new issue