Fixed git args duplication (#13411)
Because newGit() invoked twice (inside PreInstallInit() and GlobalInit()) and git parameters is global object, all git commands call with duplicated args `-c credential.helper= -c protocol.version=2`release/v1.15
parent
be880d4063
commit
7d16e6db8e
|
@ -74,6 +74,9 @@ func newGit() {
|
|||
log.Fatal("Error retrieving git version: %v", err)
|
||||
}
|
||||
|
||||
// force cleanup args
|
||||
git.GlobalCommandArgs = []string{}
|
||||
|
||||
if git.CheckGitVersionAtLeast("2.9") == nil {
|
||||
// Explicitly disable credential helper, otherwise Git credentials might leak
|
||||
git.GlobalCommandArgs = append(git.GlobalCommandArgs, "-c", "credential.helper=")
|
||||
|
|
Loading…
Reference in New Issue