Add fullTextSearch to dropdowns by default (#14694)
This PR adds `fullTextSearch: 'exact'` to most dropdown invocations meaning that if there is a search box for the dropdown it will automatically do a fullTextSearch looking for the provided fragment instead of starting at the beginning We should consider changing other places that use `fullTextSearch: true` to `'exact'` because these will be using a fuzzy-textual search that doesn't necessarily return the expected results. Fix #14689 Signed-off-by: Andrew Thornton <art27@cantab.net>release/v1.15
parent
0a9a484e1e
commit
60ef2a7c67
|
@ -74,6 +74,7 @@ export default async function initGitGraph() {
|
||||||
$('#flow-select-refs-dropdown').dropdown('set selected', dropdownSelected);
|
$('#flow-select-refs-dropdown').dropdown('set selected', dropdownSelected);
|
||||||
$('#flow-select-refs-dropdown').dropdown({
|
$('#flow-select-refs-dropdown').dropdown({
|
||||||
clearable: true,
|
clearable: true,
|
||||||
|
fullTextSeach: 'exact',
|
||||||
onRemove(toRemove) {
|
onRemove(toRemove) {
|
||||||
if (toRemove === '...flow-hide-pr-refs') {
|
if (toRemove === '...flow-hide-pr-refs') {
|
||||||
params.delete('hide-pr-refs');
|
params.delete('hide-pr-refs');
|
||||||
|
|
|
@ -2408,18 +2408,23 @@ $(document).ready(async () => {
|
||||||
});
|
});
|
||||||
|
|
||||||
// Semantic UI modules.
|
// Semantic UI modules.
|
||||||
$('.dropdown:not(.custom)').dropdown();
|
$('.dropdown:not(.custom)').dropdown({
|
||||||
|
fullTextSearch: 'exact'
|
||||||
|
});
|
||||||
$('.jump.dropdown').dropdown({
|
$('.jump.dropdown').dropdown({
|
||||||
action: 'hide',
|
action: 'hide',
|
||||||
onShow() {
|
onShow() {
|
||||||
$('.poping.up').popup('hide');
|
$('.poping.up').popup('hide');
|
||||||
}
|
},
|
||||||
|
fullTextSearch: 'exact'
|
||||||
});
|
});
|
||||||
$('.slide.up.dropdown').dropdown({
|
$('.slide.up.dropdown').dropdown({
|
||||||
transition: 'slide up'
|
transition: 'slide up',
|
||||||
|
fullTextSearch: 'exact'
|
||||||
});
|
});
|
||||||
$('.upward.dropdown').dropdown({
|
$('.upward.dropdown').dropdown({
|
||||||
direction: 'upward'
|
direction: 'upward',
|
||||||
|
fullTextSearch: 'exact'
|
||||||
});
|
});
|
||||||
$('.ui.accordion').accordion();
|
$('.ui.accordion').accordion();
|
||||||
$('.ui.checkbox').checkbox();
|
$('.ui.checkbox').checkbox();
|
||||||
|
@ -3465,6 +3470,7 @@ function initTopicbar() {
|
||||||
topicDropdown.dropdown({
|
topicDropdown.dropdown({
|
||||||
allowAdditions: true,
|
allowAdditions: true,
|
||||||
forceSelection: false,
|
forceSelection: false,
|
||||||
|
fullTextSearch: 'exact',
|
||||||
fields: {name: 'description', value: 'data-value'},
|
fields: {name: 'description', value: 'data-value'},
|
||||||
saveRemoteData: false,
|
saveRemoteData: false,
|
||||||
label: {
|
label: {
|
||||||
|
|
Loading…
Reference in New Issue