Merge pull request #314 from nuss-justin/issue/312

Fix #312. Quote file names of attachments.
2014-07-25 01:14:33 -04:00 · 2014-07-25 01:14:33 -04:00 · 30d7397f97
parent 0f3414ec39 ad7beb78d0
commit 30d7397f97
1 changed files with 3 additions and 1 deletions
--- a/routers/repo/issue.go
+++ b/routers/repo/issue.go
@ -1079,5 +1079,7 @@ func IssueGetAttachment(ctx *middleware.Context, params martini.Params) {
 		return
 	}

-	ctx.ServeFile(attachment.Path, attachment.Name)
+	// Fix #312. Attachments with , in their name are not handled correctly by Google Chrome.
+	// We must put the name in " manually.
+	ctx.ServeFile(attachment.Path, "\"" + attachment.Name + "\"")
 }