From 782344ac59e5b8ba6ce7009cebb474d1722386ec Mon Sep 17 00:00:00 2001 From: modmuss50 Date: Wed, 29 Sep 2021 19:44:26 +0100 Subject: [PATCH] Fix crash in JarProcessorManager when the input jar does not have a manifest. --- .../configuration/processors/JarProcessorManager.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/main/java/net/fabricmc/loom/configuration/processors/JarProcessorManager.java b/src/main/java/net/fabricmc/loom/configuration/processors/JarProcessorManager.java index 4c36c40..af1b2db 100644 --- a/src/main/java/net/fabricmc/loom/configuration/processors/JarProcessorManager.java +++ b/src/main/java/net/fabricmc/loom/configuration/processors/JarProcessorManager.java @@ -68,7 +68,13 @@ public class JarProcessorManager { String jarProcessorHash = getJarProcessorHash(); try (JarFile jar = new JarFile(file)) { - Attributes attributes = jar.getManifest().getMainAttributes(); + Manifest manifest = jar.getManifest(); + + if (manifest == null) { + return false; + } + + Attributes attributes = manifest.getMainAttributes(); if (!jarProcessorHash.equals(attributes.getValue(JAR_PROCESSOR_HASH_ATTRIBUTE))) { return true;