--- olm/tests/test_base64.cpp 2021-09-12 01:51:01.587794700 +0100 +++ olm/tests/test_base64.cpp 2021-09-12 01:52:11.937270600 +0100 @@ -1,6 +1,8 @@ #include "olm/base64.hh" #include "olm/base64.h" #include "unittest.hh" +#include +#include int main() { @@ -68,7 +70,6 @@ { TestCase test_case("Decoding base64 of invalid length fails with -1"); -#include std::uint8_t input[] = "SGVsbG8gV29ybGQab"; std::size_t input_length = sizeof(input) - 1; @@ -76,14 +77,12 @@ * Nothing will be written to the output buffer anyway because the input is * invalid. */ std::size_t buf_length = olm::decode_base64_length(input_length + 1); -std::uint8_t output[buf_length]; -std::uint8_t expected_output[buf_length]; -memset(output, 0, buf_length); -memset(expected_output, 0, buf_length); +std::vector output(buf_length, 0); +std::vector expected_output(buf_length, 0); -std::size_t output_length = ::_olm_decode_base64(input, input_length, output); +std::size_t output_length = ::_olm_decode_base64(input, input_length, output.data()); assert_equals(std::size_t(-1), output_length); -assert_equals(0, memcmp(output, expected_output, buf_length)); +assert_equals(0, memcmp(output.data(), expected_output.data(), buf_length)); } }