From 2b78f05aad2c192a325e9b917c527ad18244a840 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Damir=20Jeli=C4=87?= <poljar@termina.org.uk>
Date: Tue, 11 Aug 2020 09:28:28 +0200
Subject: [PATCH] crypto: More SAS tests.

---
 .../src/verification/sas/sas_state.rs         | 39 ++++++++++++++++++-
 1 file changed, 37 insertions(+), 2 deletions(-)

diff --git a/matrix_sdk_crypto/src/verification/sas/sas_state.rs b/matrix_sdk_crypto/src/verification/sas/sas_state.rs
index 8e7afbd4..3547865e 100644
--- a/matrix_sdk_crypto/src/verification/sas/sas_state.rs
+++ b/matrix_sdk_crypto/src/verification/sas/sas_state.rs
@@ -823,11 +823,11 @@ mod test {
 
     use crate::{Account, Device};
     use matrix_sdk_common::{
-        events::{EventContent, ToDeviceEvent},
+        events::{key::verification::accept::AcceptMethod, EventContent, ToDeviceEvent},
         identifiers::{DeviceId, UserId},
     };
 
-    use super::{Accepted, Created, SasState, Started};
+    use super::{Accepted, Canceled, Created, SasState, Started};
 
     fn alice_id() -> UserId {
         UserId::try_from("@alice:example.org").unwrap()
@@ -934,4 +934,39 @@ mod test {
         assert!(bob.verified_devices().contains(&bob.other_device()));
         assert!(alice.verified_devices().contains(&alice.other_device()));
     }
+
+    #[tokio::test]
+    async fn sas_invalid_commitment() {
+        let (alice, bob) = get_sas_pair().await;
+
+        let mut event = wrap_to_device_event(bob.user_id(), bob.as_content());
+
+        match &mut event.content.method {
+            AcceptMethod::MSasV1(ref mut c) => {
+                c.commitment = "".to_string();
+            }
+            _ => panic!("Unknown accept event content"),
+        }
+
+        let alice: SasState<Accepted> = alice.into_accepted(&event).unwrap();
+
+        let mut event = wrap_to_device_event(alice.user_id(), alice.as_content());
+        let bob = bob.into_key_received(&mut event).unwrap();
+        let mut event = wrap_to_device_event(bob.user_id(), bob.as_content());
+
+        alice
+            .into_key_received(&mut event)
+            .expect_err("Didn't cancel on invalid commitment");
+    }
+
+    #[tokio::test]
+    async fn sas_invalid_sender() {
+        let (alice, bob) = get_sas_pair().await;
+
+        let mut event = wrap_to_device_event(bob.user_id(), bob.as_content());
+        event.sender = UserId::try_from("@malory:example.org").unwrap();
+        alice
+            .into_accepted(&event)
+            .expect_err("Didn't cancel on a invalid sender");
+    }
 }