From 063d86af714c59b54bff4d9b69eb923c202bad3a Mon Sep 17 00:00:00 2001 From: Devin R Date: Fri, 27 Mar 2020 17:23:49 -0400 Subject: [PATCH] cargo fmt/clippy --- src/async_client.rs | 1 - src/base_client.rs | 30 +++++++++++++++++++++--------- tests/async_client_tests.rs | 6 ++++-- 3 files changed, 25 insertions(+), 12 deletions(-) diff --git a/src/async_client.rs b/src/async_client.rs index 1c53f1a0..811af61c 100644 --- a/src/async_client.rs +++ b/src/async_client.rs @@ -14,7 +14,6 @@ // limitations under the License. use futures::future::{BoxFuture, Future, FutureExt}; -use std::collections::HashMap; use std::convert::{TryFrom, TryInto}; use std::result::Result as StdResult; use std::sync::atomic::{AtomicU64, Ordering}; diff --git a/src/base_client.rs b/src/base_client.rs index 005e9140..6c1a23e2 100644 --- a/src/base_client.rs +++ b/src/base_client.rs @@ -25,7 +25,7 @@ use crate::events::room::{ aliases::AliasesEvent, canonical_alias::CanonicalAliasEvent, member::{MemberEvent, MembershipState}, - name::{NameEvent}, + name::NameEvent, }; use crate::events::EventResult; use crate::identifiers::RoomAliasId; @@ -113,16 +113,20 @@ impl RoomName { } else if !self.aliases.is_empty() { self.aliases[0].alias().to_string() } else { - // TODO - let mut names = members.values().flat_map(|m| m.display_name.clone()).take(3).collect::>(); - + // TODO + let mut names = members + .values() + .flat_map(|m| m.display_name.clone()) + .take(3) + .collect::>(); + if names.is_empty() { // TODO implement the rest of matrix-js-sdk handling of room names format!("Room {}", room_id) } else { // stabilize order names.sort(); - names.join(", ").to_string() + names.join(", ") } } } @@ -362,13 +366,21 @@ impl Client { } pub(crate) fn calculate_room_name(&self, room_id: &str) -> Option { - self.joined_rooms.get(room_id) - .and_then(|r| r.read().map(|r| r.room_name.calculate_name(room_id, &r.members)).ok()) + self.joined_rooms.get(room_id).and_then(|r| { + r.read() + .map(|r| r.room_name.calculate_name(room_id, &r.members)) + .ok() + }) } pub(crate) fn calculate_room_names(&self) -> Vec { - self.joined_rooms.iter() - .flat_map(|(id, room)| room.read().map(|r| r.room_name.calculate_name(id, &r.members)).ok()) + self.joined_rooms + .iter() + .flat_map(|(id, room)| { + room.read() + .map(|r| r.room_name.calculate_name(id, &r.members)) + .ok() + }) .collect() } diff --git a/tests/async_client_tests.rs b/tests/async_client_tests.rs index 6ecfbfec..c4eca2ae 100644 --- a/tests/async_client_tests.rs +++ b/tests/async_client_tests.rs @@ -60,7 +60,6 @@ fn sync() { assert!(rt.block_on(client.sync_token()).is_some()); } - #[test] fn timeline() { let mut rt = Runtime::new().unwrap(); @@ -88,7 +87,10 @@ fn timeline() { let _response = rt.block_on(client.sync(sync_settings)).unwrap(); assert_eq!(vec!["tutorial"], rt.block_on(client.get_room_names())); - assert_eq!(Some("tutorial".into()), rt.block_on(client.get_room_name("!SVkFJHzfwvuaIEawgC:localhost"))); + assert_eq!( + Some("tutorial".into()), + rt.block_on(client.get_room_name("!SVkFJHzfwvuaIEawgC:localhost")) + ); // rt.block_on(async { println!("{:#?}", &client.base_client().await.joined_rooms ) }); }