dendrite/syncapi/sync
Kegsay 5e9dce1c0c
syncapi: Rename and split out tokens (#1025)
* syncapi: Rename and split out tokens

Previously we used the badly named `PaginationToken` which was
used for both `/sync` and `/messages` requests. This quickly
became confusing because named fields like `PDUPosition` meant
different things depending on the token type. Instead, we now have
two token types: `TopologyToken` and `StreamingToken`, both of
which have fields which make more sense for their specific situations.

Updated the codebase to use one or the other. `PaginationToken` still
lives on as `syncToken`, an unexported type which both tokens rely on.
This allows us to guarantee that the specific mappings of positions
to a string remain solely under the control of the `types` package.
This enables us to move high-level conceptual things like
"decrement this topological token" to function calls e.g
`TopologicalToken.Decrement()`.

Currently broken because `/messages` seemingly used both stream and
topological tokens, though I need to confirm this.

* final tweaks/hacks

* spurious logging

* Review comments and linting
2020-05-13 12:14:50 +01:00
..
notifier.go syncapi: Rename and split out tokens (#1025) 2020-05-13 12:14:50 +01:00
notifier_test.go syncapi: Rename and split out tokens (#1025) 2020-05-13 12:14:50 +01:00
request.go syncapi: Rename and split out tokens (#1025) 2020-05-13 12:14:50 +01:00
requestpool.go syncapi: Rename and split out tokens (#1025) 2020-05-13 12:14:50 +01:00
userstream.go syncapi: Rename and split out tokens (#1025) 2020-05-13 12:14:50 +01:00