abf26c12f1
* Add User-Interactive Authentication And use it when deleting a device. With tests. * Make remaining sytest pass * Linting * 403 not 401 on wrong user/pass
240 lines
7 KiB
Go
240 lines
7 KiB
Go
// Copyright 2017 Paul Tötterman <paul.totterman@iki.fi>
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package routing
|
|
|
|
import (
|
|
"database/sql"
|
|
"encoding/json"
|
|
"io/ioutil"
|
|
"net/http"
|
|
|
|
"github.com/matrix-org/dendrite/clientapi/auth"
|
|
"github.com/matrix-org/dendrite/clientapi/jsonerror"
|
|
"github.com/matrix-org/dendrite/userapi/api"
|
|
"github.com/matrix-org/dendrite/userapi/storage/devices"
|
|
"github.com/matrix-org/gomatrixserverlib"
|
|
"github.com/matrix-org/util"
|
|
)
|
|
|
|
// https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-client-r0-devices
|
|
type deviceJSON struct {
|
|
DeviceID string `json:"device_id"`
|
|
DisplayName string `json:"display_name"`
|
|
LastSeenIP string `json:"last_seen_ip"`
|
|
LastSeenTS uint64 `json:"last_seen_ts"`
|
|
}
|
|
|
|
type devicesJSON struct {
|
|
Devices []deviceJSON `json:"devices"`
|
|
}
|
|
|
|
type deviceUpdateJSON struct {
|
|
DisplayName *string `json:"display_name"`
|
|
}
|
|
|
|
type devicesDeleteJSON struct {
|
|
Devices []string `json:"devices"`
|
|
}
|
|
|
|
// GetDeviceByID handles /devices/{deviceID}
|
|
func GetDeviceByID(
|
|
req *http.Request, deviceDB devices.Database, device *api.Device,
|
|
deviceID string,
|
|
) util.JSONResponse {
|
|
localpart, _, err := gomatrixserverlib.SplitID('@', device.UserID)
|
|
if err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("gomatrixserverlib.SplitID failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
ctx := req.Context()
|
|
dev, err := deviceDB.GetDeviceByID(ctx, localpart, deviceID)
|
|
if err == sql.ErrNoRows {
|
|
return util.JSONResponse{
|
|
Code: http.StatusNotFound,
|
|
JSON: jsonerror.NotFound("Unknown device"),
|
|
}
|
|
} else if err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("deviceDB.GetDeviceByID failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
return util.JSONResponse{
|
|
Code: http.StatusOK,
|
|
JSON: deviceJSON{
|
|
DeviceID: dev.ID,
|
|
DisplayName: dev.DisplayName,
|
|
},
|
|
}
|
|
}
|
|
|
|
// GetDevicesByLocalpart handles /devices
|
|
func GetDevicesByLocalpart(
|
|
req *http.Request, deviceDB devices.Database, device *api.Device,
|
|
) util.JSONResponse {
|
|
localpart, _, err := gomatrixserverlib.SplitID('@', device.UserID)
|
|
if err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("gomatrixserverlib.SplitID failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
ctx := req.Context()
|
|
deviceList, err := deviceDB.GetDevicesByLocalpart(ctx, localpart)
|
|
|
|
if err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("deviceDB.GetDevicesByLocalpart failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
res := devicesJSON{}
|
|
|
|
for _, dev := range deviceList {
|
|
res.Devices = append(res.Devices, deviceJSON{
|
|
DeviceID: dev.ID,
|
|
DisplayName: dev.DisplayName,
|
|
})
|
|
}
|
|
|
|
return util.JSONResponse{
|
|
Code: http.StatusOK,
|
|
JSON: res,
|
|
}
|
|
}
|
|
|
|
// UpdateDeviceByID handles PUT on /devices/{deviceID}
|
|
func UpdateDeviceByID(
|
|
req *http.Request, deviceDB devices.Database, device *api.Device,
|
|
deviceID string,
|
|
) util.JSONResponse {
|
|
localpart, _, err := gomatrixserverlib.SplitID('@', device.UserID)
|
|
if err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("gomatrixserverlib.SplitID failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
ctx := req.Context()
|
|
dev, err := deviceDB.GetDeviceByID(ctx, localpart, deviceID)
|
|
if err == sql.ErrNoRows {
|
|
return util.JSONResponse{
|
|
Code: http.StatusNotFound,
|
|
JSON: jsonerror.NotFound("Unknown device"),
|
|
}
|
|
} else if err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("deviceDB.GetDeviceByID failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
if dev.UserID != device.UserID {
|
|
return util.JSONResponse{
|
|
Code: http.StatusForbidden,
|
|
JSON: jsonerror.Forbidden("device not owned by current user"),
|
|
}
|
|
}
|
|
|
|
defer req.Body.Close() // nolint: errcheck
|
|
|
|
payload := deviceUpdateJSON{}
|
|
|
|
if err := json.NewDecoder(req.Body).Decode(&payload); err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("json.NewDecoder.Decode failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
if err := deviceDB.UpdateDevice(ctx, localpart, deviceID, payload.DisplayName); err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("deviceDB.UpdateDevice failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
return util.JSONResponse{
|
|
Code: http.StatusOK,
|
|
JSON: struct{}{},
|
|
}
|
|
}
|
|
|
|
// DeleteDeviceById handles DELETE requests to /devices/{deviceId}
|
|
func DeleteDeviceById(
|
|
req *http.Request, userInteractiveAuth *auth.UserInteractive, deviceDB devices.Database, device *api.Device,
|
|
deviceID string,
|
|
) util.JSONResponse {
|
|
ctx := req.Context()
|
|
defer req.Body.Close() // nolint:errcheck
|
|
bodyBytes, err := ioutil.ReadAll(req.Body)
|
|
if err != nil {
|
|
return util.JSONResponse{
|
|
Code: http.StatusBadRequest,
|
|
JSON: jsonerror.BadJSON("The request body could not be read: " + err.Error()),
|
|
}
|
|
}
|
|
login, errRes := userInteractiveAuth.Verify(ctx, bodyBytes, device)
|
|
if errRes != nil {
|
|
return *errRes
|
|
}
|
|
|
|
localpart, _, err := gomatrixserverlib.SplitID('@', device.UserID)
|
|
if err != nil {
|
|
util.GetLogger(ctx).WithError(err).Error("gomatrixserverlib.SplitID failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
// make sure that the access token being used matches the login creds used for user interactive auth, else
|
|
// 1 compromised access token could be used to logout all devices.
|
|
if login.Username() != localpart && login.Username() != device.UserID {
|
|
return util.JSONResponse{
|
|
Code: 403,
|
|
JSON: jsonerror.Forbidden("Cannot delete another user's device"),
|
|
}
|
|
}
|
|
|
|
if err := deviceDB.RemoveDevice(ctx, deviceID, localpart); err != nil {
|
|
util.GetLogger(ctx).WithError(err).Error("deviceDB.RemoveDevice failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
return util.JSONResponse{
|
|
Code: http.StatusOK,
|
|
JSON: struct{}{},
|
|
}
|
|
}
|
|
|
|
// DeleteDevices handles POST requests to /delete_devices
|
|
func DeleteDevices(
|
|
req *http.Request, deviceDB devices.Database, device *api.Device,
|
|
) util.JSONResponse {
|
|
localpart, _, err := gomatrixserverlib.SplitID('@', device.UserID)
|
|
if err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("gomatrixserverlib.SplitID failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
ctx := req.Context()
|
|
payload := devicesDeleteJSON{}
|
|
|
|
if err := json.NewDecoder(req.Body).Decode(&payload); err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("json.NewDecoder.Decode failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
defer req.Body.Close() // nolint: errcheck
|
|
|
|
if err := deviceDB.RemoveDevices(ctx, localpart, payload.Devices); err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("deviceDB.RemoveDevices failed")
|
|
return jsonerror.InternalServerError()
|
|
}
|
|
|
|
return util.JSONResponse{
|
|
Code: http.StatusOK,
|
|
JSON: struct{}{},
|
|
}
|
|
}
|