char/dendrite
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

mediaapi/fileutils: Fix and comment os.IsNotExist bug

Browse source
This commit is contained in:
Robert Swain 2017-05-31 07:08:21 +02:00
parent 63ccd770c6
commit a4300eefc4
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/github.com/matrix-org/dendrite/mediaapi/fileutils/fileutils.go
View file

@ -76,7 +76,9 @@ func MoveFileWithHashCheck(tmpDir types.Path, mediaMetadata *types.MediaMetadata
}
var stat os.FileInfo
if stat, err = os.Stat(finalPath); os.IsExist(err) {
// Note: The double-negative is intentional as os.IsExist(err) != !os.IsNotExist(err).
// The functions are error checkers to be used in different cases.
if stat, err = os.Stat(finalPath); !os.IsNotExist(err) {
duplicate = true
if stat.Size() == int64(mediaMetadata.FileSizeBytes) {
return types.Path(finalPath), duplicate, nil