Add whitelist/blacklist maintenance complainer to buildkite annotations (#870)

main
Andrew Morgan 2020-02-14 13:07:14 +00:00 committed by GitHub
parent b6ea1bc67a
commit 409fec2a48
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 3 deletions

View File

@ -76,14 +76,30 @@ while read -r test_name; do
fi fi
done <<< "${passed_but_expected_fail}" done <<< "${passed_but_expected_fail}"
# TODO: Check that the same test doesn't exist in both the whitelist and blacklist
# TODO: Check that the same test doesn't appear twice in the whitelist|blacklist
# Trim test output strings
tests_to_add=$(echo -e $tests_to_add | xargs)
already_in_whitelist=$(echo -e $already_in_whitelist | xargs)
# Format output with markdown for buildkite annotation rendering purposes
if [ -n "${tests_to_add}" ] && [ -n "${already_in_whitelist}" ]; then
echo "### 📜 SyTest Whitelist Maintenance"
fi
if [ -n "${tests_to_add}" ]; then if [ -n "${tests_to_add}" ]; then
echo "ERROR: The following passed tests are not present in $2. Please append them to the file:" echo "**ERROR**: The following tests passed but are not present in \`$2\`. Please append them to the file:"
echo "\`\`\`"
echo -e "${tests_to_add}" echo -e "${tests_to_add}"
echo "\`\`\`"
fi fi
if [ -n "${already_in_whitelist}" ]; then if [ -n "${already_in_whitelist}" ]; then
echo "WARN: Tests in the whitelist still marked as expected fail:" echo "**WARN**: Tests in the whitelist still marked as **expected fail**:"
echo "\`\`\`"
echo -e "${already_in_whitelist}" echo -e "${already_in_whitelist}"
echo "\`\`\`"
fi fi
exit ${fail_build} exit ${fail_build}

View File

@ -183,7 +183,6 @@ GET /directory/room/:room_alias yields room ID
PUT /directory/room/:room_alias creates alias PUT /directory/room/:room_alias creates alias
Room aliases can contain Unicode Room aliases can contain Unicode
Creators can delete alias Creators can delete alias
Alias creators can delete canonical alias with no ops
Regular users cannot create room aliases within the AS namespace Regular users cannot create room aliases within the AS namespace
Deleting a non-existent alias should return a 404 Deleting a non-existent alias should return a 404
Users can't delete other's aliases Users can't delete other's aliases